> On Dec. 29, 2014, 4:14 p.m., Amareshwari Sriramadasu wrote: > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java, > > line 132 > > <https://reviews.apache.org/r/29110/diff/3/?file=802327#file802327line132> > > > > Cannot this set be moved to constructor itself? > > Amareshwari Sriramadasu wrote: > I see this is marked fixed. But setter is called still in many places?
this is needed since the QueryContext is created in QESImpl and the rewritten query is set on the drivers during phase 1 rewrite. Cant be merged with Context constructor - Suma ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29110/#review66268 ----------------------------------------------------------- On Jan. 5, 2015, 7:08 a.m., Suma Shivaprasad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29110/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2015, 7:08 a.m.) > > > Review request for lens and Amareshwari Sriramadasu. > > > Bugs: LENS-24 > https://issues.apache.org/jira/browse/LENS-24 > > > Repository: lens > > > Description > ------- > > LENS-24 - Changes to plugin Query Rewriter > > > RewriteUtil changes > -> had 2 rewrite phases now - rewriteToCubeQL and rewriteToHQL > -> rewriteToHQL operates on getRewrittenQuery instead of getUserQuery() > > > Diffs > ----- > > lens-cube/pom.xml f6f47c7 > lens-cube/src/main/java/org/apache/lens/driver/cube/RewriteUtil.java > d2da97d > > lens-cube/src/test/java/org/apache/lens/driver/cube/TestMinCostSelector.java > 1981757 > lens-cube/src/test/java/org/apache/lens/driver/cube/TestRewriting.java > 796a582 > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java > cd1a0c7 > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java > 9c17749 > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java > ce62b65 > lens-examples/src/main/resources/dim3-storage-tables.xml 213138a > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 0ae539e > > lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java > c1d4954 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java > 5dab13b > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockQueryContext.java > 749ef60 > lens-server/pom.xml cd4ccaf > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 9521136 > lens-server/src/main/java/org/apache/lens/server/query/RewriteUtil.java > PRE-CREATION > lens-server/src/main/resources/lensserver-default.xml 986c714 > > lens-server/src/test/java/org/apache/lens/server/query/DummyQueryRewriter.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > 7edc3bc > lens-server/src/test/java/org/apache/lens/server/query/TestRewriting.java > PRE-CREATION > lens-server/src/test/resources/lens-site.xml ebf4ddb > src/site/apt/admin/config.apt 67741a2 > > Diff: https://reviews.apache.org/r/29110/diff/ > > > Testing > ------- > > > Thanks, > > Suma Shivaprasad > >
