----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29110/#review66812 -----------------------------------------------------------
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java <https://reviews.apache.org/r/29110/#comment110445> Can we have a single util to create context and calls proper setters? lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java <https://reviews.apache.org/r/29110/#comment110451> call it phase1RewrittenQuery? lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java <https://reviews.apache.org/r/29110/#comment110454> Can we have only this setter and remove others? lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java <https://reviews.apache.org/r/29110/#comment110456> Can you add unit test to check conf getting set from rewrite phase1 and available in query and driver confs? - Amareshwari Sriramadasu On Jan. 6, 2015, 8:26 a.m., Suma Shivaprasad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29110/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2015, 8:26 a.m.) > > > Review request for lens and Amareshwari Sriramadasu. > > > Bugs: LENS-24 > https://issues.apache.org/jira/browse/LENS-24 > > > Repository: lens > > > Description > ------- > > LENS-24 - Changes to plugin Query Rewriter > > > RewriteUtil changes > -> had 2 rewrite phases now - rewriteToCubeQL and rewriteToHQL > -> rewriteToHQL operates on getRewrittenQuery instead of getUserQuery() > > > Diffs > ----- > > lens-client/pom.xml fa771e4 > lens-cube/pom.xml f6f47c7 > lens-cube/src/main/java/org/apache/lens/driver/cube/RewriteUtil.java > d2da97d > > lens-cube/src/test/java/org/apache/lens/driver/cube/TestMinCostSelector.java > 1981757 > lens-cube/src/test/java/org/apache/lens/driver/cube/TestRewriting.java > 796a582 > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java > cd1a0c7 > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java > 9c17749 > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java > ce62b65 > lens-examples/src/main/resources/dim3-storage-tables.xml 213138a > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 0ae539e > > lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java > c1d4954 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java > 5dab13b > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockQueryContext.java > 749ef60 > lens-server/pom.xml cd4ccaf > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 9521136 > lens-server/src/main/java/org/apache/lens/server/query/RewriteUtil.java > PRE-CREATION > lens-server/src/main/resources/lensserver-default.xml 986c714 > > lens-server/src/test/java/org/apache/lens/server/query/DummyQueryRewriter.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > 7edc3bc > lens-server/src/test/java/org/apache/lens/server/query/TestRewriting.java > PRE-CREATION > lens-server/src/test/resources/lens-site.xml ebf4ddb > src/site/apt/admin/config.apt 67741a2 > > Diff: https://reviews.apache.org/r/29110/diff/ > > > Testing > ------- > > > Thanks, > > Suma Shivaprasad > >
