> On Jan. 20, 2015, 11:16 a.m., Amareshwari Sriramadasu wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java, > > line 336 > > <https://reviews.apache.org/r/30030/diff/2/?file=826254#file826254line336> > > > > Please add javadoc for the method. > > And also deprecate the api, as saying use of this is deprecated and > > will removed soon. Cache gets updated automatically whenever there is alter. > > > > Should we just remove this from server-api and cast to impl in resource > > class, directly? > > Rajat Khandelwal wrote: > removing doesn't change anything for the user. user just has access to > the resource method.
We cannot always think user is just end user who is running query. There can be developers who use api and write applications on top of api provided. For any api change, we should look for how it will impact other developers. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30030/#review68707 ----------------------------------------------------------- On Jan. 20, 2015, 1:44 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30030/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2015, 1:44 p.m.) > > > Review request for lens. > > > Bugs: LENS-201 > https://issues.apache.org/jira/browse/LENS-201 > > > Repository: lens > > > Description > ------- > > methods to clear cache added > > Need to add automatic calls when updation of dims/facts is called. (Can't > ensure. Maybe the instance is in a separate JVM) > > Also need to add test cases (Can't add. Only use case is creating client > instance in separate jvm) > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > 42f5e0a295fd1171313708eadc9b7eddf5076989 > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 9ef89f656d05bfc305ca466ed448ff57cd76f3d6 > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > 7194f6c5860df619398378c41176fe9c85b1446b > > Diff: https://reviews.apache.org/r/30030/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
