> On Jan. 22, 2015, 2:54 a.m., Jaideep dhok wrote: > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java, > > line 1496 > > <https://reviews.apache.org/r/30030/diff/6/?file=827848#file827848line1496> > > > > Since this call is updating server state, GET should not be used. > > DELETE is most appropriate here.
Agree with Jaideep, should be DELETE > On Jan. 22, 2015, 2:54 a.m., Jaideep dhok wrote: > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java, > > line 1359 > > <https://reviews.apache.org/r/30030/diff/6/?file=827847#file827847line1359> > > > > Why are we adding a *new* deprecated method? We dont want to expose this method to user in later releases, system will update cache whenever the tables are altered. Since lens-cube api is public now, which is allowing users to directly alter tables without going through lens server. Another way is to move CubeMetastoreClient into server module and make is package private. But that would break clients. I'm fine doing this too and not provide any method to clear cache. Thoughts? - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30030/#review69119 ----------------------------------------------------------- On Jan. 21, 2015, 10:33 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30030/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 10:33 a.m.) > > > Review request for lens. > > > Bugs: LENS-201 > https://issues.apache.org/jira/browse/LENS-201 > > > Repository: lens > > > Description > ------- > > methods to clear cache added > > Also unit tests for the same > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > 42f5e0a295fd1171313708eadc9b7eddf5076989 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > f9e9f3d4103c3ad982abced549ae5f27779289c1 > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 9ef89f656d05bfc305ca466ed448ff57cd76f3d6 > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > 7194f6c5860df619398378c41176fe9c85b1446b > > Diff: https://reviews.apache.org/r/30030/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.536s] > [INFO] Lens .............................................. SUCCESS [1.745s] > [INFO] Lens API .......................................... SUCCESS [5.991s] > [INFO] Lens API for server and extensions ................ SUCCESS [6.048s] > [INFO] Lens Cube ......................................... SUCCESS [7:12.670s] > [INFO] Lens DB storage ................................... SUCCESS [15.278s] > [INFO] Lens Query Library ................................ SUCCESS [6.321s] > [INFO] Lens Hive Driver .................................. SUCCESS [3:06.060s] > [INFO] Lens Driver for Cloudera Impala ................... SUCCESS [3.366s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [28.842s] > [INFO] Lens Server ....................................... SUCCESS [5:11.066s] > [INFO] Lens client ....................................... SUCCESS [21.685s] > [INFO] Lens CLI .......................................... SUCCESS [1:58.382s] > [INFO] Lens Examples ..................................... SUCCESS [1.140s] > [INFO] Lens Distribution ................................. SUCCESS [3.912s] > [INFO] Lens Client Distribution .......................... SUCCESS [7.264s] > [INFO] Lens ML Lib ....................................... SUCCESS [48.514s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 20:01.906s > [INFO] Finished at: Wed Jan 21 10:16:56 UTC 2015 > [INFO] Final Memory: 112M/1094M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Rajat Khandelwal > >
