-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30454/
-----------------------------------------------------------
(Updated Feb. 2, 2015, 6:32 a.m.)
Review request for lens.
Bugs: LENS-254
https://issues.apache.org/jira/browse/LENS-254
Repository: lens
Description (updated)
-------
We are keeping Map<Table, List<Error>> in cubequerycontext. To club the errors,
I reversed the map to form Map<Error, List<Table>>. Next, List<Table> was
converted to a comma_separated_list_of_tables. So we have Map<Error,
comma_separated_list_of_tables>, now to show it as a json, I was reversing it
again to form Map<comma_separated_list_of_tables, Error> which was wrong. This
change modifies the last step to obtain Map<comma_separated_list_of_tables,
List<Error>>. In the *wrong* approach `NO_FACT_UPDATE_PERIODS_FOR_GIVEN_RANGE`
was overridden by some other error but it was present neverthless. While
calculating brief error it was used but in final detailed json it was
overridden. With this change this will not happen.
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java
3f86c6023b78f77b6cdf6fb6fe7187e35bfd0821
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java
00483368311f704e1c009542533db11caa9f3bc6
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java
fad50b0d543f50cbb391afd4e00d75ca0ba261e6
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java
d14b095df7dc60c1acd0b507f739fb44e5646952
lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java
c48cba9e9bdd88946b76369b1c4595d0167ffd14
Diff: https://reviews.apache.org/r/30454/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.111s]
[INFO] Lens .............................................. SUCCESS [1.895s]
[INFO] Lens API .......................................... SUCCESS [5.495s]
[INFO] Lens API for server and extensions ................ SUCCESS [5.609s]
[INFO] Lens Cube ......................................... SUCCESS [6:31.507s]
[INFO] Lens DB storage ................................... SUCCESS [9.774s]
[INFO] Lens Query Library ................................ SUCCESS [5.009s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:39.088s]
[INFO] Lens Driver for Cloudera Impala ................... SUCCESS [3.004s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [27.784s]
[INFO] Lens Server ....................................... SUCCESS [4:30.127s]
[INFO] Lens client ....................................... SUCCESS [19.703s]
[INFO] Lens CLI .......................................... SUCCESS [1:33.683s]
[INFO] Lens Examples ..................................... SUCCESS [1.128s]
[INFO] Lens Distribution ................................. SUCCESS [5.426s]
[INFO] Lens Client Distribution .......................... SUCCESS [6.604s]
[INFO] Lens ML Lib ....................................... SUCCESS [42.438s]
[INFO] Lens Regression ................................... SUCCESS [0.437s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:31.669s
[INFO] Finished at: Fri Jan 30 15:42:18 UTC 2015
[INFO] Final Memory: 100M/1077M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
