----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30454/#review70557 -----------------------------------------------------------
Ship it! Current changes look fine. But the error message can be improved. We can park a jira. - Amareshwari Sriramadasu On Feb. 2, 2015, 10:16 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30454/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2015, 10:16 a.m.) > > > Review request for lens. > > > Bugs: LENS-254 > https://issues.apache.org/jira/browse/LENS-254 > > > Repository: lens > > > Description > ------- > > We are keeping Map<Table, List<Error>> in cubequerycontext. To club the > errors, I reversed the map to form Map<Error, List<Table>>. Next, List<Table> > was converted to a comma_separated_list_of_tables. So we have Map<Error, > comma_separated_list_of_tables>, now to show it as a json, I was reversing it > again to form Map<comma_separated_list_of_tables, Error> which was wrong. > This change modifies the last step to obtain > Map<comma_separated_list_of_tables, List<Error>>. In the *wrong* approach > `NO_FACT_UPDATE_PERIODS_FOR_GIVEN_RANGE` was overridden by some other error > but it was present neverthless. While calculating brief error it was used but > in final detailed json it was overridden. With this change this will not > happen. > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java > 0d62ba85bc389d306771eb922fb49841278fa384 > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java > 394d6df6f3b5c4246637b205dc7b6dcdfdcd5021 > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > 04b9653dde1f38fe8520f06adc451aab2fd8a710 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > 390dee45f553af36676fd39bee75a90052fdec61 > > lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java > 35c6da0581eea790dd2d52eb4707f0a37b53394e > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java > 7d8339bc36bc6ff9ad6c2ba9db045bdfb280e804 > > lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java > 628a4f52745ea92b202c23ad3484ef9c5f127faa > > lens-cube/src/main/java/org/apache/lens/cube/parse/LightestDimensionResolver.java > 7a27a08c700904aa704f858d70ac647b5ea1a525 > > lens-cube/src/main/java/org/apache/lens/cube/parse/LightestFactResolver.java > 85cd75a2798c9afaca8761c8b0dcea101a599dc2 > lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java > 3f86c6023b78f77b6cdf6fb6fe7187e35bfd0821 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > 9d06c55cb008682c21dbee8c83c5e7e418b29641 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java > 00483368311f704e1c009542533db11caa9f3bc6 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > fad50b0d543f50cbb391afd4e00d75ca0ba261e6 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java > d14b095df7dc60c1acd0b507f739fb44e5646952 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java > c48cba9e9bdd88946b76369b1c4595d0167ffd14 > > Diff: https://reviews.apache.org/r/30454/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.257s] > [INFO] Lens .............................................. SUCCESS [1.816s] > [INFO] Lens API .......................................... SUCCESS [5.259s] > [INFO] Lens API for server and extensions ................ SUCCESS [5.721s] > [INFO] Lens Cube ......................................... SUCCESS [7:44.112s] > [INFO] Lens DB storage ................................... SUCCESS [11.519s] > [INFO] Lens Query Library ................................ SUCCESS [6.716s] > [INFO] Lens Hive Driver .................................. SUCCESS [3:16.637s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [33.102s] > [INFO] Lens Server ....................................... SUCCESS [5:28.334s] > [INFO] Lens client ....................................... SUCCESS [24.388s] > [INFO] Lens CLI .......................................... SUCCESS [2:02.830s] > [INFO] Lens Examples ..................................... SUCCESS [1.487s] > [INFO] Lens Distribution ................................. SUCCESS [5.802s] > [INFO] Lens Client Distribution .......................... SUCCESS [8.731s] > [INFO] Lens ML Lib ....................................... SUCCESS [52.013s] > [INFO] Lens Regression ................................... SUCCESS [0.587s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 21:12.185s > [INFO] Finished at: Mon Feb 02 10:07:25 UTC 2015 > [INFO] Final Memory: 109M/1049M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Rajat Khandelwal > >
