> On Feb. 16, 2015, 10:26 a.m., Amareshwari Sriramadasu wrote: > > lens-client/src/test/resources/lens-client-site.xml, line 27 > > <https://reviews.apache.org/r/31080/diff/1/?file=864920#file864920line27> > > > > Will all tests be using this? > > > > Should we move this TestLensClient as a set on config object? > > > > Also, i dont see any changes with respect to reading this config > > anywhere. > > > > Can you add the config in lens-client-default.xml with description? > > Jaideep dhok wrote: > This is an existing config which is read in > LensClientConfig.getLensDatabase. Already present in lens-client-default.xml > Since lens-client module has only two unit tests, I think should be OK?
I would say go ahead and do a set in TestLensClient, because the creation of the db is happening inside the test. And the other test cannot be run alone with this change. The other test might also fail with db not found some times. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31080/#review72603 ----------------------------------------------------------- On Feb. 16, 2015, 10:12 a.m., Jaideep dhok wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31080/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2015, 10:12 a.m.) > > > Review request for lens. > > > Bugs: LENS-297 > https://issues.apache.org/jira/browse/LENS-297 > > > Repository: lens > > > Description > ------- > > LENS-297 Accept db to be set as part of open session call > > > Diffs > ----- > > lens-client/src/main/java/org/apache/lens/client/LensConnection.java > 2458620f0de1ebce1c0f383e19cb7de63875c3da > lens-client/src/test/java/org/apache/lens/client/TestLensClient.java > 1563104d637192b19f9fb0a54dc8829db53af0a0 > lens-client/src/test/java/org/apache/lens/jdbc/JDBCUrlParserTest.java > 3c9787872a9a8d985e810e8b8453bd36efcb9b02 > lens-client/src/test/resources/lens-client-site.xml PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java > 88d48691d5665f64c9d225fcbb8e3084eb548597 > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > 61e2d22a71108c08e0775e2ee5eaf8639bde9318 > > lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java > 22a9440c02f8a5ba152a0d70d42b7150ef592a1f > lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java > c32edb4df8e9c9b572dcb45d4c304a2c1d269ffa > > lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java > 78ffc87959813e38d9c120517030bff415606562 > > Diff: https://reviews.apache.org/r/31080/diff/ > > > Testing > ------- > > Added unit test to verify DB is set as part of open call. > Changed existing unit test in TestLensClient to validate DB is set from > lens-client-site.xml > > No impact on existing tests. Will update test output once finished. > > > Thanks, > > Jaideep dhok > >
