> On Feb. 16, 2015, 10:49 a.m., Raju Bairishetti wrote: > > lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java, > > line 112 > > <https://reviews.apache.org/r/31080/diff/1/?file=864924#file864924line112> > > > > I think we should make changes in session.js file also.
@Raju for UI, more changes are required. We can create a follow up JIRA for this. - Jaideep ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31080/#review72605 ----------------------------------------------------------- On Feb. 16, 2015, 11:15 a.m., Jaideep dhok wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31080/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2015, 11:15 a.m.) > > > Review request for lens. > > > Bugs: LENS-297 > https://issues.apache.org/jira/browse/LENS-297 > > > Repository: lens > > > Description > ------- > > LENS-297 Accept db to be set as part of open session call > > > Diffs > ----- > > lens-client/src/main/java/org/apache/lens/client/LensConnection.java > 2458620f0de1ebce1c0f383e19cb7de63875c3da > lens-client/src/test/java/org/apache/lens/client/TestLensClient.java > 1563104d637192b19f9fb0a54dc8829db53af0a0 > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java > 88d48691d5665f64c9d225fcbb8e3084eb548597 > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > 61e2d22a71108c08e0775e2ee5eaf8639bde9318 > > lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java > 22a9440c02f8a5ba152a0d70d42b7150ef592a1f > lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java > c32edb4df8e9c9b572dcb45d4c304a2c1d269ffa > > lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java > 78ffc87959813e38d9c120517030bff415606562 > > Diff: https://reviews.apache.org/r/31080/diff/ > > > Testing > ------- > > Added unit test to verify DB is set as part of open call. > Changed existing unit test in TestLensClient to validate DB is set from > lens-client-site.xml > > No impact on existing tests. > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [3.425s] > [INFO] Lens .............................................. SUCCESS [2.945s] > [INFO] Lens API .......................................... SUCCESS [9.587s] > [INFO] Lens API for server and extensions ................ SUCCESS [8.119s] > [INFO] Lens Cube ......................................... SUCCESS [8:16.296s] > [INFO] Lens DB storage ................................... SUCCESS [15.630s] > [INFO] Lens Query Library ................................ SUCCESS [12.831s] > [INFO] Lens Hive Driver .................................. SUCCESS [4:08.784s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [34.877s] > [INFO] Lens Server ....................................... SUCCESS > [16:46.913s] > [INFO] Lens client ....................................... SUCCESS [32.455s] > [INFO] Lens CLI .......................................... SUCCESS [3:48.513s] > [INFO] Lens Examples ..................................... SUCCESS [1.367s] > [INFO] Lens Distribution ................................. SUCCESS [6.879s] > [INFO] Lens Client Distribution .......................... SUCCESS [7.282s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:27.915s] > [INFO] Lens Regression ................................... SUCCESS [0.555s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 36:44.977s > [INFO] Finished at: Mon Feb 16 16:23:33 IST 2015 > [INFO] Final Memory: 135M/832M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Jaideep dhok > >
