-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31106/
-----------------------------------------------------------

Review request for lens, Himanshu Gahlaut, Jaideep dhok, Rajat Khandelwal, and 
Srikanth Sundarrajan.


Bugs: LENS-274
    https://issues.apache.org/jira/browse/LENS-274


Repository: lens


Description
-------

Changes include :

- Adds REST api with ESTIMATE submit option for POST on queryapi/queries, which 
returns EstimateResult - which contains QueryCost, if successful, error 
otherwise.
- Adds estimate in HiveDriver which does explain for native table queries and 
nothing for OLAP queries
- Adds estimate in JDBCDriver which does explain for all queries
- Driver selection logic changed to call estimate instead of explain
- Added unit tests for drivers and server

Still todo :
Priority calculation logic still needs QueryPlan. Will fix this and update patch


Diffs
-----

  lens-api/src/main/java/org/apache/lens/api/query/EstimateResult.java 
PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java 
ee64081 
  lens-api/src/main/java/org/apache/lens/api/query/SubmitOp.java 37e6f55 
  lens-cube/src/main/java/org/apache/lens/driver/cube/RewriteUtil.java 4f284a7 
  lens-cube/src/test/java/org/apache/lens/driver/cube/TestMinCostSelector.java 
95aed16 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
6da1884 
  
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 
0b118de 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
5e8163e 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java 
8ad8d03 
  
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 
0af38b1 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 
c732e09 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java
 9fc5b20 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java
 31ad625 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java
 313d5a7 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java
 971c7db 
  
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 
02bf324 
  
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockFailDriver.java
 433914a 
  
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 ca22b04 
  
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java
 8d6037f 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
9b3ae68 

Diff: https://reviews.apache.org/r/31106/diff/


Testing
-------

Tests passed in lens-driver-hive and lens-driver-jdbc. TestQueryService passes. 
Will update all test results.


Thanks,

Amareshwari Sriramadasu

Reply via email to