----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31106/#review73113 -----------------------------------------------------------
Ship it! Ship It! - Rajat Khandelwal On Feb. 18, 2015, 6:36 p.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31106/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2015, 6:36 p.m.) > > > Review request for lens, Himanshu Gahlaut, Jaideep dhok, Rajat Khandelwal, > and Srikanth Sundarrajan. > > > Bugs: LENS-327 > https://issues.apache.org/jira/browse/LENS-327 > > > Repository: lens > > > Description > ------- > > Changes include : > > - Adds REST api with ESTIMATE submit option for POST on queryapi/queries, > which returns EstimateResult - which contains QueryCost, if successful, error > otherwise. > - Adds estimate in HiveDriver which does explain for native table queries and > nothing for OLAP queries > - Adds estimate in JDBCDriver which does explain for all queries > - Driver selection logic changed to call estimate instead of explain > - Added unit tests for drivers and server > > Priority calculation logic still needs QueryPlan. Calling explain as part of > execute in this patch. > Created https://issues.apache.org/jira/browse/LENS-323 to use cube query > context for priority. > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/query/EstimateResult.java > PRE-CREATION > lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java > ee64081 > lens-api/src/main/java/org/apache/lens/api/query/SubmitOp.java 37e6f55 > lens-cube/src/main/java/org/apache/lens/driver/cube/RewriteUtil.java > 4f284a7 > > lens-cube/src/test/java/org/apache/lens/driver/cube/TestMinCostSelector.java > 95aed16 > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > 6da1884 > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java > e4b5fcc > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java > 0b118de > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java > 5e8163e > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java > 8ad8d03 > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java > 0af38b1 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java > c732e09 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java > 9fc5b20 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java > 31ad625 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java > 313d5a7 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java > 971c7db > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java > 02bf324 > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockFailDriver.java > 433914a > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > ca22b04 > > lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java > 8d6037f > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > 9b3ae68 > > Diff: https://reviews.apache.org/r/31106/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.799s] > [INFO] Lens .............................................. SUCCESS [2.046s] > [INFO] Lens API .......................................... SUCCESS [6.501s] > [INFO] Lens API for server and extensions ................ SUCCESS [5.257s] > [INFO] Lens Cube ......................................... SUCCESS [6:39.334s] > [INFO] Lens DB storage ................................... SUCCESS [9.939s] > [INFO] Lens Query Library ................................ SUCCESS [5.275s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:37.085s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [23.503s] > [INFO] Lens Server ....................................... SUCCESS [4:30.442s] > [INFO] Lens client ....................................... SUCCESS [24.899s] > [INFO] Lens CLI .......................................... SUCCESS [1:58.019s] > [INFO] Lens Examples ..................................... SUCCESS [0.857s] > [INFO] Lens Distribution ................................. SUCCESS [10.422s] > [INFO] Lens ML Lib ....................................... SUCCESS [43.884s] > [INFO] Lens Regression ................................... SUCCESS [0.453s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 18:00.586s > [INFO] Finished at: Tue Feb 17 09:32:35 UTC 2015 > [INFO] Final Memory: 97M/1218M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Amareshwari Sriramadasu > >
