> On March 23, 2015, 6:37 p.m., Amareshwari Sriramadasu wrote: > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java, > > line 36 > > <https://reviews.apache.org/r/32393/diff/1/?file=902982#file902982line36> > > > > Planning to move this lens-cube module since this priority gets > > calculated only for cube queries. > > > > Also, this can be used by other drivers directly to prioritize queries > > in that driver. > > > > Thoughts?
Maybe we can add a factory for priority decider and decide a particular implementation based on conf. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32393/#review77392 ----------------------------------------------------------- On March 23, 2015, 6:35 p.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32393/ > ----------------------------------------------------------- > > (Updated March 23, 2015, 6:35 p.m.) > > > Review request for lens, Jaideep dhok and Rajat Khandelwal. > > > Bugs: LENS-323 > https://issues.apache.org/jira/browse/LENS-323 > > > Repository: lens > > > Description > ------- > > WIP patch for early comments. > > Changes include: > > - Generating rewriter plan with cube queries involved > - Populating FactPartitions queried in RewriterPlan > - priority getting set only for cube queries; native tables queries are left > with defaults > - TestHiveDriver.testPriority updated > > Still pending > - Fix other test failures > - Add unit tests for rewriter plan construction > - Clear transient state in QueryContext after launch. > > Can be included or done in a followup > - Constructing driver plan from RewriterPlan, instead of parsing output. > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateDim.java > 3ac207e > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java > 66c3b25 > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTable.java > 5eaf7ec > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > df5a212 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > c29d88f > lens-cube/src/main/java/org/apache/lens/driver/cube/RewriteUtil.java > 8ed4070 > lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java > PRE-CREATION > lens-driver-hive/pom.xml 3b8e73a > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > 9e3c723 > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java > 64a6bba > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java > 4f471cb > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java > 8a5839b > lens-driver-hive/src/test/resources/priority_tests.data 230df95 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java > 38ebc55 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java > fef834f > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java > 67c73b8 > > Diff: https://reviews.apache.org/r/32393/diff/ > > > Testing > ------- > > > Thanks, > > Amareshwari Sriramadasu > >
