----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32393/#review77526 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java <https://reviews.apache.org/r/32393/#comment125623> Might need null check on some of the ASTs lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java <https://reviews.apache.org/r/32393/#comment125624> Do we still need to do this check after rewriter as completed? Won't rewriter make sure that all tables are present? lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java <https://reviews.apache.org/r/32393/#comment125627> Should be unsupported operation exception lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java <https://reviews.apache.org/r/32393/#comment125628> Same as above lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java <https://reviews.apache.org/r/32393/#comment125629> What is the priority set to in this case? lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java <https://reviews.apache.org/r/32393/#comment125638> Can we make all weight values final lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java <https://reviews.apache.org/r/32393/#comment125632> Needs a hasNext check on iterator. lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java <https://reviews.apache.org/r/32393/#comment125636> 1. How are we setting cost for dim tables? 2. This cost computation needs more explanation. What is the reasoning behind this formula? Why do we have a table weight AND a partition weight? I think table weights could be aggregated from the partitions themselves. lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java <https://reviews.apache.org/r/32393/#comment125643> These are default partition costs for update periods - MONTHLY = 15 DAILY = 0.75 HOURLY = 0.04 (Assuming we change it to 1.0f/24) So what we are saying is that a monthly partition is 20 times as expensive as a daily partition, and 375 times as expensive as an hourly partition. Do you think this will hold for vast majority of cases? Our defaults should be tuned accordingly. lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java <https://reviews.apache.org/r/32393/#comment125641> This is always zero. We should do 1.0f/24 - Jaideep dhok On March 23, 2015, 1:05 p.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32393/ > ----------------------------------------------------------- > > (Updated March 23, 2015, 1:05 p.m.) > > > Review request for lens, Jaideep dhok and Rajat Khandelwal. > > > Bugs: LENS-323 > https://issues.apache.org/jira/browse/LENS-323 > > > Repository: lens > > > Description > ------- > > WIP patch for early comments. > > Changes include: > > - Generating rewriter plan with cube queries involved > - Populating FactPartitions queried in RewriterPlan > - priority getting set only for cube queries; native tables queries are left > with defaults > - TestHiveDriver.testPriority updated > > Still pending > - Fix other test failures > - Add unit tests for rewriter plan construction > - Clear transient state in QueryContext after launch. > > Can be included or done in a followup > - Constructing driver plan from RewriterPlan, instead of parsing output. > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateDim.java > 3ac207e > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java > 66c3b25 > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTable.java > 5eaf7ec > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > df5a212 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > c29d88f > lens-cube/src/main/java/org/apache/lens/driver/cube/RewriteUtil.java > 8ed4070 > lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java > PRE-CREATION > lens-driver-hive/pom.xml 3b8e73a > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > 9e3c723 > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java > 64a6bba > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java > 4f471cb > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java > 8a5839b > lens-driver-hive/src/test/resources/priority_tests.data 230df95 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java > 38ebc55 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java > fef834f > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java > 67c73b8 > > Diff: https://reviews.apache.org/r/32393/diff/ > > > Testing > ------- > > > Thanks, > > Amareshwari Sriramadasu > >
