----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33210/#review80907 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java <https://reviews.apache.org/r/33210/#comment131074> Remove commented code? lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java <https://reviews.apache.org/r/33210/#comment131076> Why is copy of CandidateTablePruneCode required? Does copy constructor of CandidateTablePruneCode take care of copying all fields? lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java <https://reviews.apache.org/r/33210/#comment131078> Can you update rewriter flow documentation above? lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java <https://reviews.apache.org/r/33210/#comment131081> Was this an existing bug? Why is 1 changed to 0 ? Can you also update/add unit test in TestDateUtil? - Amareshwari Sriramadasu On April 20, 2015, 1:52 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33210/ > ----------------------------------------------------------- > > (Updated April 20, 2015, 1:52 p.m.) > > > Review request for lens. > > > Bugs: LENS-481, LENS-482 and LENS-503 > https://issues.apache.org/jira/browse/LENS-481 > https://issues.apache.org/jira/browse/LENS-482 > https://issues.apache.org/jira/browse/LENS-503 > > > Repository: lens > > > Description > ------- > > just after fact partitions are resolved. > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java > 44c691548dbcd00676c7d3b9c6a8b5eee5910baf > > lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java > 8d80f0ba56fdaff112f67125a0f163ad32a6cd02 > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java > 2c191fc13ec2b38f0b19a446a78f03601255c693 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > 0df4b2ec9e657e2cacc77168362f9095e068afc4 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java > 24c6ab18a61e0dba8dc3a7218c34a1a0532053e7 > lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java > a4988d4189ee2a0dd273c3b549b46258bce9222c > > lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java > PRE-CREATION > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > ab2c3f96158fa4001ba2855f31ab45484cfce4de > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 19baa00bfca3c7b3c536f3aaa865e224db909288 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java > 71f328f79bb4fda179947bae6759ddc93c0f43ee > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > b85f60e7a4bc724ad5328e64138c217ca3d58ab7 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryMetrics.java > 5cf76ca906cea51f3f206419fcd77190966bede1 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java > 544f4a099334795749410db934d00d9fde6bcaf2 > > Diff: https://reviews.apache.org/r/33210/diff/ > > > Testing > ------- > > Cube tests all passing > > > Thanks, > > Rajat Khandelwal > >
