> On April 22, 2015, 3:42 p.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java, > > line 48 > > <https://reviews.apache.org/r/33210/diff/6-7/?file=937709#file937709line48> > > > > Is false the default value of FAIL_QUERY_ON_PARTIAL_DATA? I think it is > > default is true.
`StorageTableResolver` has the exact same line. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33210/#review81138 ----------------------------------------------------------- On April 22, 2015, 3:37 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33210/ > ----------------------------------------------------------- > > (Updated April 22, 2015, 3:37 p.m.) > > > Review request for lens. > > > Bugs: LENS-481, LENS-482 and LENS-503 > https://issues.apache.org/jira/browse/LENS-481 > https://issues.apache.org/jira/browse/LENS-482 > https://issues.apache.org/jira/browse/LENS-503 > > > Repository: lens > > > Description > ------- > > just after fact partitions are resolved. > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java > 44c691548dbcd00676c7d3b9c6a8b5eee5910baf > > lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/EndsAndHolesPartitionTimeline.java > 10b18e229eb3e250e494950d0ae0838339d0879d > > lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java > 8d80f0ba56fdaff112f67125a0f163ad32a6cd02 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/StoreAllPartitionTimeline.java > 2364400e98e2c617513ee0598360e3b3b32e3fb4 > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java > 2c191fc13ec2b38f0b19a446a78f03601255c693 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > 0df4b2ec9e657e2cacc77168362f9095e068afc4 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java > 24c6ab18a61e0dba8dc3a7218c34a1a0532053e7 > lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java > a4988d4189ee2a0dd273c3b549b46258bce9222c > > lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java > PRE-CREATION > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > ab2c3f96158fa4001ba2855f31ab45484cfce4de > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 19baa00bfca3c7b3c536f3aaa865e224db909288 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java > 71f328f79bb4fda179947bae6759ddc93c0f43ee > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > b85f60e7a4bc724ad5328e64138c217ca3d58ab7 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestDateUtil.java > 9efd1f7b5d9f324cd7e23f451c6b31f5b88096bd > lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryMetrics.java > 5cf76ca906cea51f3f206419fcd77190966bede1 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java > 544f4a099334795749410db934d00d9fde6bcaf2 > > Diff: https://reviews.apache.org/r/33210/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.090s] > [INFO] Lens .............................................. SUCCESS [2.827s] > [INFO] Lens API .......................................... SUCCESS [16.351s] > [INFO] Lens API for server and extensions ................ SUCCESS [25.065s] > [INFO] Lens Cube ......................................... SUCCESS [3:24.852s] > [INFO] Lens DB storage ................................... SUCCESS [18.344s] > [INFO] Lens Query Library ................................ SUCCESS [15.135s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:49.561s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [31.999s] > [INFO] Lens Server ....................................... SUCCESS [5:01.653s] > [INFO] Lens client ....................................... SUCCESS [35.610s] > [INFO] Lens CLI .......................................... SUCCESS [2:56.711s] > [INFO] Lens Examples ..................................... SUCCESS [11.095s] > [INFO] Lens Distribution ................................. SUCCESS [12.161s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:16.975s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.780s] > [INFO] Lens Regression ................................... SUCCESS [0.474s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 18:24.678s > [INFO] Finished at: Tue Apr 21 11:18:19 UTC 2015 > [INFO] Final Memory: 110M/1240M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Rajat Khandelwal > >
