----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33467/#review81270 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/metadata/DerivedCube.java <https://reviews.apache.org/r/33467/#comment131562> Why is volatile required? lens-cube/src/main/java/org/apache/lens/cube/metadata/DerivedCube.java <https://reviews.apache.org/r/33467/#comment131563> If we just put synchronized outside the first if statement, we don't need two checks and the suppress check comment. - Jaideep dhok On April 23, 2015, 5:31 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33467/ > ----------------------------------------------------------- > > (Updated April 23, 2015, 5:31 a.m.) > > > Review request for lens, Jaideep dhok and Rajat Khandelwal. > > > Bugs: LENS-522 > https://issues.apache.org/jira/browse/LENS-522 > > > Repository: lens > > > Description > ------- > > ConcurrentModificationException is happening because of getDimAttributes() > getting called from two threads - which are populating cachedDims. Changes > put up fixes that > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/metadata/DerivedCube.java > ab5dbec > > Diff: https://reviews.apache.org/r/33467/diff/ > > > Testing > ------- > > > Thanks, > > Amareshwari Sriramadasu > >
