> On April 23, 2015, 5:42 a.m., Jaideep dhok wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/DerivedCube.java, 
> > line 65
> > <https://reviews.apache.org/r/33467/diff/1/?file=940234#file940234line65>
> >
> >     Why is volatile required?

Was requied for DoubleCheckedLockingCheck. Removed now.


- Amareshwari


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33467/#review81270
-----------------------------------------------------------


On April 23, 2015, 5:31 a.m., Amareshwari Sriramadasu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33467/
> -----------------------------------------------------------
> 
> (Updated April 23, 2015, 5:31 a.m.)
> 
> 
> Review request for lens, Jaideep dhok and Rajat Khandelwal.
> 
> 
> Bugs: LENS-522
>     https://issues.apache.org/jira/browse/LENS-522
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> ConcurrentModificationException is happening because of getDimAttributes() 
> getting called from two threads - which are populating cachedDims. Changes 
> put up fixes that
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/DerivedCube.java 
> ab5dbec 
> 
> Diff: https://reviews.apache.org/r/33467/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Amareshwari Sriramadasu
> 
>

Reply via email to