----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33578/#review81794 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java <https://reviews.apache.org/r/33578/#comment132284> push.where.tohaving ? lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java <https://reviews.apache.org/r/33578/#comment132285> I thought this should be part of AggregateResolver, not Groupby resolver. was that wrong? - Amareshwari Sriramadasu On April 27, 2015, 11:10 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33578/ > ----------------------------------------------------------- > > (Updated April 27, 2015, 11:10 a.m.) > > > Review request for lens. > > > Bugs: LENS-464 > https://issues.apache.org/jira/browse/LENS-464 > > > Repository: lens > > > Description > ------- > > posting early to get early comments. > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java > a6374f6540b70446dfff968eafb71914285e7607 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > b7c3ee95f7275f78b5e87377de59720f1bdd9ade > lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java > 6a2a897659f646bdb1d86b394e944e9dd34ed8f3 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > 097f2283b7defb2fe5703cf04f3dc276f18e341b > > Diff: https://reviews.apache.org/r/33578/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
