----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33578/#review82661 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java <https://reviews.apache.org/r/33578/#comment133449> Can you add some comments around whats happening in this method? lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java <https://reviews.apache.org/r/33578/#comment133447> Why is the AST added with AND ? if query is "select a from table where msr1 > 100 or msr2 < 100 and time_range_in (dt, t1, t2)", how does where get promoted to having with changes put up? lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java <https://reviews.apache.org/r/33578/#comment133444> Move the test to TestAggregateResolver ? lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java <https://reviews.apache.org/r/33578/#comment133445> Can we add tests with aggregate resolver - on and off, and where to having - on and off ? Basically all cases described in jira and assert the expected behavior. - Amareshwari Sriramadasu On May 6, 2015, 8:47 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33578/ > ----------------------------------------------------------- > > (Updated May 6, 2015, 8:47 a.m.) > > > Review request for lens. > > > Bugs: LENS-464 > https://issues.apache.org/jira/browse/LENS-464 > > > Repository: lens > > > Description > ------- > > posting early to get early comments. > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java > a25fae641c6486b68d244ff233d0b6a827e41f9c > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java > a6374f6540b70446dfff968eafb71914285e7607 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > b7c3ee95f7275f78b5e87377de59720f1bdd9ade > lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java > 6a2a897659f646bdb1d86b394e944e9dd34ed8f3 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > c9153530925d53ab9b1dc580e0b6a8aef6be3fb0 > > Diff: https://reviews.apache.org/r/33578/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.017s] > [INFO] Lens .............................................. SUCCESS [2.784s] > [INFO] Lens API .......................................... SUCCESS [20.420s] > [INFO] Lens API for server and extensions ................ SUCCESS [25.560s] > [INFO] Lens Cube ......................................... SUCCESS [4:42.769s] > [INFO] Lens DB storage ................................... SUCCESS [34.815s] > [INFO] Lens Query Library ................................ SUCCESS [30.412s] > [INFO] Lens Hive Driver .................................. SUCCESS [3:40.487s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [34.821s] > [INFO] Lens Server ....................................... SUCCESS [6:06.862s] > [INFO] Lens client ....................................... SUCCESS [1:04.212s] > [INFO] Lens CLI .......................................... SUCCESS [3:40.587s] > [INFO] Lens Examples ..................................... SUCCESS [9.449s] > [INFO] Lens Distribution ................................. SUCCESS [10.715s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:19.058s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.813s] > [INFO] Lens Regression ................................... SUCCESS [6.348s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 23:35.107s > [INFO] Finished at: Wed May 06 08:07:22 UTC 2015 > [INFO] Final Memory: 108M/1318M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Rajat Khandelwal > >
