----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33581/#review82813 -----------------------------------------------------------
lens-examples/src/main/resources/sales-cube.xml <https://reviews.apache.org/r/33581/#comment133639> Shouldnt this be dt = ot + [1hour,20days) ? lens-api/src/main/resources/cube-0.1.xsd <https://reviews.apache.org/r/33581/#comment133640> Needs changes with new format change. lens-api/src/main/resources/cube-0.1.xsd <https://reviews.apache.org/r/33581/#comment133642> Should the definition be always on partition column or optionally time dimension will also work? In examples : Time dimension : order_time, part column : ot Should the definition be always on ot? Should we accept definition for time dimension, for the cases where there is no explicit mapping to part column ? I'm thinking actually we should take the definiion to be on time dimension instead of part column sothat all time dimensions (with a corresponding part column exists or not) can specify a fallback partition. lens-api/src/main/resources/cube-0.1.xsd <https://reviews.apache.org/r/33581/#comment133641> Can you give more details here ? Is space between number and unit supported? Are 4 days, 4days, 4day, 4 day same ? lens-api/src/main/resources/cube-0.1.xsd <https://reviews.apache.org/r/33581/#comment133643> Can you mention if the value is not specified, the value in cube definition will be used. - Amareshwari Sriramadasu On May 7, 2015, 9:59 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33581/ > ----------------------------------------------------------- > > (Updated May 7, 2015, 9:59 a.m.) > > > Review request for lens. > > > Bugs: LENS-198 > https://issues.apache.org/jira/browse/LENS-198 > > > Repository: lens > > > Description > ------- > > Allow timed dimensions to be a field and not a time partitioning column. > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd > 10b1dfa32072952bc43b093e039ff282096d39cc > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > 01d76c073f7dd3739d465f5ba0ff9cb5b7bdd5d5 > lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java > 8a6dcbabff70d6cfa5a3ef2e434fda50ef397770 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java > 74a26feec12cd3630ab06d8a714ad05fcec9e9ec > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 8e2c9ed23670934a76d931ad6eb018bcf203dedf > lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java > f644c16bf1d7f2b686ded11e0f4821ed7aa3f553 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java > 1837ae9a2eec1ba9b20c6b0eca2390691f236a1c > > lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRangeList.java > PRE-CREATION > > lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java > 8a533fc949d040477377900ffd4445e35dfe3c80 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java > 66467183d4e397257e613668681acb75a10ca92e > lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java > a65bc96f0dbc6d0694e538ece68c7dd38a78a24b > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java > 47b9fc1ed678550d929b234bb6742635390df8ba > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java > 165525d083f78b1c6a00fec6811efb3549c696b8 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > b7c3ee95f7275f78b5e87377de59720f1bdd9ade > lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java > 82c43a7387b87d98cfd64dde4c85e0a4c5d6834c > > lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java > f5d2115d885cc7a88061543267f0d6c49882d884 > lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java > e200b12ae7bcef800c138c0db2b3ceb0d0b028ef > lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java > 8a23dedfbd6bba03099eceb7f44a6acf20dc0a62 > lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java > c81cf344f16114f0d67f255f9f8f486aecfda957 > lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java > 766769f64da062ab4417745cdd1ef110fe0bf933 > lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java > ddabc25f7a4c1d6fdc4c272685690600d651176a > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java > a41424a06a904a08b4f0c8ac294a6eebdf7902e6 > > lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java > fcc611481ae152faaeabb2b6aa4a94f192823359 > > lens-cube/src/main/java/org/apache/lens/cube/parse/PartitionRangesForPartitionColumns.java > PRE-CREATION > > lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java > beaa5517d67dcb4561bd8fad8fc0a304d36b0ca2 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > e5a6b32472ec7094459f60d0c7cd16d49a131ba6 > lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java > 612cdf9b39f82efea0f8197f1daabe4a85994775 > lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java > 1a30228d59d53cc0f3ea6ff6d2fd76340907dd93 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 32033541a822f87e80b8236c6ca2d2e34b99ed6c > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java > 37c578bd81caeb56170f3da8aade3ecaacc3a8f4 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java > b1d7a3203ad5e169930a3dddf6a9fdf55d5cc66a > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > c9153530925d53ab9b1dc580e0b6a8aef6be3fb0 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java > 29240b69b990a0b962c2103a30ed87093236ded9 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java > 06de5cdafa705dc6570b42e32b47ad914327700a > lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java > 79d9be30de1a270a801cbbaaf1b8b399d4103033 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java > bd519716e3069558f634d8dbb0c08b113b66f2d1 > > lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java > 7883b15d5c0c946e29722a6b02e89eb810b36d72 > lens-examples/src/main/resources/cube-queries.sql > 7a0b542a00e27a6a68d94f26b17bba881afadfe4 > lens-examples/src/main/resources/customer.xml > 64024f1ba9e3d0cb58dd0b4de62f7b91bc81159e > lens-examples/src/main/resources/sales-aggr-fact2-local-parts.xml > 35a88019c07dd98f4b55c10debb92afe84f85dde > lens-examples/src/main/resources/sales-aggr-fact2.xml > b535a875300528074d499e11ae545034529bb6e5 > lens-examples/src/main/resources/sales-cube.xml > f5e2f93f50fafd750554d80de15e1a9d2c166b6c > > Diff: https://reviews.apache.org/r/33581/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.197s] > [INFO] Lens .............................................. SUCCESS [3.371s] > [INFO] Lens API .......................................... SUCCESS [26.972s] > [INFO] Lens API for server and extensions ................ SUCCESS [36.260s] > [INFO] Lens Cube ......................................... SUCCESS [4:27.436s] > [INFO] Lens DB storage ................................... SUCCESS [33.380s] > [INFO] Lens Query Library ................................ SUCCESS [29.792s] > [INFO] Lens Hive Driver .................................. SUCCESS [3:31.969s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [33.706s] > [INFO] Lens Server ....................................... SUCCESS [4:52.979s] > [INFO] Lens client ....................................... SUCCESS [41.132s] > [INFO] Lens CLI .......................................... SUCCESS [3:07.546s] > [INFO] Lens Examples ..................................... SUCCESS [9.252s] > [INFO] Lens Distribution ................................. SUCCESS [11.228s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:19.637s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.691s] > [INFO] Lens Regression ................................... SUCCESS [7.449s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 21:18.026s > [INFO] Finished at: Thu May 07 08:59:21 UTC 2015 > [INFO] Final Memory: 113M/1253M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Rajat Khandelwal > >
