> On May 6, 2015, 5:43 p.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java, line 90 > > <https://reviews.apache.org/r/33581/diff/6/?file=950872#file950872line90> > > > > Whats the purpose of this formatter ?
For writing date in HQL. Hive expects a certain format of date fields. > On May 6, 2015, 5:43 p.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java, line > > 65 > > <https://reviews.apache.org/r/33581/diff/6/?file=950874#file950874line65> > > > > Why is the order changed? Doesnt it cause test failures? post selection where clause is now null always. Earlier it was used to add not latest condition. Not latest condition is removed from here as well as test cases. Hence no test failure. > On May 6, 2015, 5:43 p.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java, > > line 364 > > <https://reviews.apache.org/r/33581/diff/6/?file=950883#file950883line364> > > > > fallBackRange returned could be null. Do we need to handle null here? No. If null, it'll just append `null`. Won't throw NPE. http://stackoverflow.com/questions/4260723/concatenating-null-strings-in-java > On May 6, 2015, 5:43 p.m., Amareshwari Sriramadasu wrote: > > lens-examples/src/main/resources/sales-cube.xml, line 151 > > <https://reviews.apache.org/r/33581/diff/6/?file=950894#file950894line151> > > > > What does it mean in terms for order time and delivery time? Is ti > > saying delivery time is any time between order_time + 1hr to 20 days? Precisely. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33581/#review82663 ----------------------------------------------------------- On May 6, 2015, 2:39 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33581/ > ----------------------------------------------------------- > > (Updated May 6, 2015, 2:39 p.m.) > > > Review request for lens. > > > Bugs: LENS-198 > https://issues.apache.org/jira/browse/LENS-198 > > > Repository: lens > > > Description > ------- > > Allow timed dimensions to be a field and not a time partitioning column. > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > 01d76c073f7dd3739d465f5ba0ff9cb5b7bdd5d5 > lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java > 8a6dcbabff70d6cfa5a3ef2e434fda50ef397770 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java > 74a26feec12cd3630ab06d8a714ad05fcec9e9ec > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 8e2c9ed23670934a76d931ad6eb018bcf203dedf > lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java > f644c16bf1d7f2b686ded11e0f4821ed7aa3f553 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java > 1837ae9a2eec1ba9b20c6b0eca2390691f236a1c > > lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRangeList.java > PRE-CREATION > > lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java > 8a533fc949d040477377900ffd4445e35dfe3c80 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java > 66467183d4e397257e613668681acb75a10ca92e > lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java > a65bc96f0dbc6d0694e538ece68c7dd38a78a24b > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java > 47b9fc1ed678550d929b234bb6742635390df8ba > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java > 165525d083f78b1c6a00fec6811efb3549c696b8 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > b7c3ee95f7275f78b5e87377de59720f1bdd9ade > lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java > 82c43a7387b87d98cfd64dde4c85e0a4c5d6834c > > lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java > f5d2115d885cc7a88061543267f0d6c49882d884 > lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java > e200b12ae7bcef800c138c0db2b3ceb0d0b028ef > lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java > 8a23dedfbd6bba03099eceb7f44a6acf20dc0a62 > lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java > fa23b8e42452552c9d400fcfa20d5d099458ffbc > lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java > 766769f64da062ab4417745cdd1ef110fe0bf933 > lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java > ddabc25f7a4c1d6fdc4c272685690600d651176a > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java > a41424a06a904a08b4f0c8ac294a6eebdf7902e6 > > lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java > fcc611481ae152faaeabb2b6aa4a94f192823359 > > lens-cube/src/main/java/org/apache/lens/cube/parse/PartitionRangesForPartitionColumns.java > PRE-CREATION > > lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java > beaa5517d67dcb4561bd8fad8fc0a304d36b0ca2 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > e5a6b32472ec7094459f60d0c7cd16d49a131ba6 > lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java > 612cdf9b39f82efea0f8197f1daabe4a85994775 > lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java > 1a30228d59d53cc0f3ea6ff6d2fd76340907dd93 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 32033541a822f87e80b8236c6ca2d2e34b99ed6c > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java > 37c578bd81caeb56170f3da8aade3ecaacc3a8f4 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java > b1d7a3203ad5e169930a3dddf6a9fdf55d5cc66a > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > c9153530925d53ab9b1dc580e0b6a8aef6be3fb0 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java > 29240b69b990a0b962c2103a30ed87093236ded9 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java > 06de5cdafa705dc6570b42e32b47ad914327700a > lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java > 79d9be30de1a270a801cbbaaf1b8b399d4103033 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java > bd519716e3069558f634d8dbb0c08b113b66f2d1 > lens-examples/src/main/resources/sales-cube.xml > 951ace98e7872e60395f3c3201ea2ecf8e03d577 > > lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java > 25173ebacf0733114593cee2fe0d3c28c6ea2885 > > Diff: https://reviews.apache.org/r/33581/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.775s] > [INFO] Lens .............................................. SUCCESS [2.729s] > [INFO] Lens API .......................................... SUCCESS [19.890s] > [INFO] Lens API for server and extensions ................ SUCCESS [21.948s] > [INFO] Lens Cube ......................................... SUCCESS [3:34.024s] > [INFO] Lens DB storage ................................... SUCCESS [19.125s] > [INFO] Lens Query Library ................................ SUCCESS [20.968s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:50.229s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [32.597s] > [INFO] Lens Server ....................................... SUCCESS [5:54.523s] > [INFO] Lens client ....................................... SUCCESS [45.558s] > [INFO] Lens CLI .......................................... SUCCESS [3:46.349s] > [INFO] Lens Examples ..................................... SUCCESS [16.021s] > [INFO] Lens Distribution ................................. SUCCESS [17.832s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:21.802s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.962s] > [INFO] Lens Regression ................................... SUCCESS [8.135s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 20:57.456s > [INFO] Finished at: Wed May 06 09:07:01 UTC 2015 > [INFO] Final Memory: 115M/1373M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Rajat Khandelwal > >
