----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33976/#review83381 -----------------------------------------------------------
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java <https://reviews.apache.org/r/33976/#comment134365> I suppose as we are loading entire results in memory, this won't work for large result sets? We should stream from the socket input stream directly to the file. Otherwise, it kind of defeats the purpose since most likely people would want to dump large result sets to a file. - Jaideep dhok On May 8, 2015, 12:30 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33976/ > ----------------------------------------------------------- > > (Updated May 8, 2015, 12:30 p.m.) > > > Review request for lens. > > > Bugs: LENS-26 > https://issues.apache.org/jira/browse/LENS-26 > > > Repository: lens > > > Description > ------- > > option to download result into a file > > > Diffs > ----- > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java > c0616d2a2f7c98d89b4fcaff76f7c6f9d8b35730 > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java > d7b63724f50dc392a5440ce8362b4eb6ca81f885 > src/site/apt/user/cli.apt cbbc3eb9e173f891baf0c7f765efe1a6c5bfa23f > > Diff: https://reviews.apache.org/r/33976/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
