> On May 19, 2015, 12:12 p.m., Amareshwari Sriramadasu wrote:
> > lens-client/src/main/java/org/apache/lens/client/LensClient.java, line 155
> > <https://reviews.apache.org/r/33976/diff/5/?file=962593#file962593line155>
> >
> > If httpResultSet is not available, we should say result not
> > downloadable to user, and guideline message should be given on how he can
> > fetch the result
Current design: If http result is there, or if in memory result is there, then
it'll be saved to the directory provided with file name `{query_handle}.csv`.
Else, the message that comes about the driver persistent queries will be
printed.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33976/#review84269
-----------------------------------------------------------
On May 20, 2015, 7:31 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33976/
> -----------------------------------------------------------
>
> (Updated May 20, 2015, 7:31 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-26
> https://issues.apache.org/jira/browse/LENS-26
>
>
> Repository: lens
>
>
> Description
> -------
>
> option to download result into a file
>
>
> Diffs
> -----
>
> checkstyle/src/main/resources/checkstyle.xml
> 236f977f58f41cd3fee2ebe8445f38dd4a1f0d3b
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java
> 8707fec5612a04e9a07ed9d5e38f342ef1f9114e
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java
> 05922e394e5fea9e95e67d56d04697ebf438f48d
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDStoragePartitionCommand.java
> 0d53e2107be116d4dbb855f247b57be0c1b97691
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java
> 64e9ca47c5c7df444cdd16b2d55bc738d6c945bc
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java
> d7b63724f50dc392a5440ce8362b4eb6ca81f885
> lens-cli/src/test/java/org/apache/lens/cli/doc/TestGenerateCLIUserDoc.java
> 508690743aa39011722cd56f9ad649d5c83de9c7
> lens-client/src/main/java/org/apache/lens/client/LensClient.java
> 016e4ab1285582760b5da47b355402b747ea78e8
> lens-client/src/main/java/org/apache/lens/client/LensStatement.java
> 5ce3a82926ed2bad6f29300d24a18b4cadbe0e4b
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java
> 43985bad1571e6899679551674cea76e6196e8f8
>
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java
> a953ec6a2117fa48e0a2ced4daa1f8d8d4e15731
>
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java
> 36a48b9ea48eb89780f5c98dc396ae5f176d1bd4
>
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java
> f11d8834d4010a1e7c616c6c3dd5ff90a6c577c5
>
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java
> 0f4e990512beab0fdb0b8e51c08b165e97494a9b
>
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
> 3bf180c9ab6f2a9fec6259848ebf65ecd147cfcf
> src/site/apt/user/cli.apt bd394972790792905cb21dd0da5894840f404d8e
>
> Diff: https://reviews.apache.org/r/33976/diff/
>
>
> Testing
> -------
>
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.818s]
> [INFO] Lens .............................................. SUCCESS [3.293s]
> [INFO] Lens API .......................................... SUCCESS [20.626s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.116s]
> [INFO] Lens Cube ......................................... SUCCESS [3:30.556s]
> [INFO] Lens DB storage ................................... SUCCESS [21.408s]
> [INFO] Lens Query Library ................................ SUCCESS [15.581s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:56.842s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [37.111s]
> [INFO] Lens Server ....................................... SUCCESS [5:22.697s]
> [INFO] Lens client ....................................... SUCCESS [37.577s]
> [INFO] Lens CLI .......................................... SUCCESS [3:18.496s]
> [INFO] Lens Examples ..................................... SUCCESS [9.647s]
> [INFO] Lens Distribution ................................. SUCCESS [8.324s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.860s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.076s]
> [INFO] Lens Regression ................................... SUCCESS [8.223s]
> [INFO]
> ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
