----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34417/#review84452 -----------------------------------------------------------
Can you update cube-0.1.xsd as well - to say if valid columns property value length exceeds 3999, it should be passed as property[0-N], each with max 3999 length string? - Amareshwari Sriramadasu On May 19, 2015, 5:12 p.m., Akshay Goyal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34417/ > ----------------------------------------------------------- > > (Updated May 19, 2015, 5:12 p.m.) > > > Review request for lens. > > > Bugs: LENS-563 > https://issues.apache.org/jira/browse/LENS-563 > > > Repository: lens > > > Description > ------- > > Currently, lens accept valid column names of a fact through a property - upto > length of 4000. We need to support valid columns of length more than this. > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > 9daccec > > Diff: https://reviews.apache.org/r/34417/diff/ > > > Testing > ------- > > Existing test cases passed. > > > Thanks, > > Akshay Goyal > >
