----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34417/#review84461 -----------------------------------------------------------
Ship it! lens-api/src/main/resources/cube-0.1.xsd <https://reviews.apache.org/r/34417/#comment135751> Seems we need to set cube.fact.{fact-name}.valid.columns.size as well. Can you update doc accordingly? - Amareshwari Sriramadasu On May 20, 2015, 4:30 a.m., Akshay Goyal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34417/ > ----------------------------------------------------------- > > (Updated May 20, 2015, 4:30 a.m.) > > > Review request for lens. > > > Bugs: LENS-563 > https://issues.apache.org/jira/browse/LENS-563 > > > Repository: lens > > > Description > ------- > > Currently, lens accept valid column names of a fact through a property - upto > length of 4000. We need to support valid columns of length more than this. > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd 06f85ee > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > 9daccec > > Diff: https://reviews.apache.org/r/34417/diff/ > > > Testing > ------- > > Existing test cases passed. > > > Thanks, > > Akshay Goyal > >
