> On May 25, 2015, 2:57 a.m., Raju Bairishetti wrote: > > lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java, > > line 164 > > <https://reviews.apache.org/r/34105/diff/5/?file=971183#file971183line164> > > > > Can we use workspace(i.e. target directory) for test files creation. In > > this way we are testing for relative paths also. > > > > We can have String filenameA = **"target/data_a";** instead of > > "/tmp/data_a";
Implemented. > On May 25, 2015, 2:57 a.m., Raju Bairishetti wrote: > > lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java, > > line 199 > > <https://reviews.apache.org/r/34105/diff/5/?file=971183#file971183line199> > > > > I am thinking that we are passing the absolute paths in both tests. Can > > we pass relative paths in the **testFileCommandsWithRegex** in the method? > > > > Can we rename the testHdfsFileCommandsWithRegex method name also as we > > are not testing the hdfs files? Makes sense. Implemented. > On May 25, 2015, 2:57 a.m., Raju Bairishetti wrote: > > lens-server/src/main/java/org/apache/lens/server/util/PathScanner.java, > > line 69 > > <https://reviews.apache.org/r/34105/diff/5/?file=971185#file971185line69> > > > > Can we avoid uri parsing? Can we get fsPath and fs like this? > > > > fsPath = new Path(path); > > fs = fsPath.getFileSystem(new Configuration()); > > > > @amareshwari/@prongs any comments/suggestions? Its basically the same thing - I can make changes based on suggestions. Path#getFileSystem does the same thing- public FileSystem getFileSystem(Configuration conf) throws IOException { return FileSystem.get(this.toUri(), conf); } - Yash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34105/#review85106 ----------------------------------------------------------- On May 25, 2015, 6:09 a.m., Yash Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34105/ > ----------------------------------------------------------- > > (Updated May 25, 2015, 6:09 a.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > Initial patch for - add jar should be able to take regex path and should be > able to add multiple jars. > > Jira: https://issues.apache.org/jira/browse/LENS-513 > > > Diffs > ----- > > > lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java > 3238edb > > lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java > 5ffc086 > lens-server/src/main/java/org/apache/lens/server/util/PathScanner.java > PRE-CREATION > lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java > 01dcf54 > > Diff: https://reviews.apache.org/r/34105/diff/ > > > Testing > ------- > > Yes. > > Testcases: > New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex > Old testcase modified: TestLensConnectionCliCommands#testJarCommands > > Test on CLI: > > 1. -ve test scenario: > lens-shell>add jar /home/yash/Desktop/rt.jarr > No Jars found in the specified path. > lens-shell>add jar /home/yash/Desktop/*.jarr > No Jars found in the specified path. > > 2. +ve test scenario: > lens-shell>add jar /home/yash/Desktop/*.jar > Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar > /home/yash/Desktop/rt.jar ] > > lens-shell>list resources > type=jar path=/home/yash/Desktop/mahout-core-0.9.jar > type=jar path=/home/yash/Desktop/rt.jar > > > Complete build with testcases: > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 > s] > [INFO] Lens ............................................... SUCCESS [ 3.751 > s] > [INFO] Lens API ........................................... SUCCESS [ 19.844 > s] > [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 > s] > [INFO] Lens Cube .......................................... SUCCESS [03:06 > min] > [INFO] Lens DB storage .................................... SUCCESS [ 22.211 > s] > [INFO] Lens Query Library ................................. SUCCESS [ 19.126 > s] > [INFO] Lens Hive Driver ................................... SUCCESS [02:48 > min] > [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 > s] > [INFO] Lens Server ........................................ SUCCESS [06:03 > min] > [INFO] Lens client ........................................ SUCCESS [ 41.219 > s] > [INFO] Lens CLI ........................................... SUCCESS [02:09 > min] > [INFO] Lens Examples ...................................... SUCCESS [ 11.513 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 9.081 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [01:19 > min] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 > s] > [INFO] Lens Regression .................................... SUCCESS [ 8.067 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 18:46 min > [INFO] Finished at: 2015-05-12T19:44:01+05:30 > [INFO] Final Memory: 120M/389M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Yash Sharma > >
