> On May 27, 2015, 3:07 p.m., Rajat Khandelwal wrote: > > lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java, > > line 98 > > <https://reviews.apache.org/r/34105/diff/7/?file=971535#file971535line98> > > > > I believe the name is misleading. It's neither taking `URI`, nor > > returning `Path`
Fixed. This name was a side effect of naming the method similar to existing method ```createNewPath()``` > On May 27, 2015, 3:07 p.m., Rajat Khandelwal wrote: > > lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java, > > line 203 > > <https://reviews.apache.org/r/34105/diff/7/?file=971535#file971535line203> > > > > why does only this have `file://` and others have `file:`? This is on purpose. I wanted to test file path with both formats. Have added a comment with the info. > On May 27, 2015, 3:07 p.m., Rajat Khandelwal wrote: > > lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java, > > line 258 > > <https://reviews.apache.org/r/34105/diff/7/?file=971535#file971535line258> > > > > A lot of code is common in testing jar commands and testing file > > commands. Can we unify them? Done. > On May 27, 2015, 3:07 p.m., Rajat Khandelwal wrote: > > lens-server/src/main/java/org/apache/lens/server/util/PathScanner.java, > > line 44 > > <https://reviews.apache.org/r/34105/diff/7/?file=971537#file971537line44> > > > > `Path Scanner`, by name should be able to scan any given path. This is > > counter-intuitive to the class design here, which says that path scanner > > only scans one path. > > > > With the current design, all use cases will be: > > > > `paths = new PathScanner(a, b).getPaths()` > > > > Leaving the reader to wonder if `getPaths()` has to be called always, > > why isn't it part of the constructor. > > > > I'd suggest let's have a class like `ScannedPath`(very crude name, I'm > > sure you can come up with something better), and have it implement > > `Iterable<String>`. This will allow you to do `for(String path: new > > ScannedPath(path))`. Implemented. PLease review. On May 27, 2015, 3:07 p.m., Yash Sharma wrote: > > Are we not doing the `jar_order` thing? Yes we are. Please review the logic in ``` /** * Filters the matchedPath[] to remove unwanted resources * and apply ordering to the resources as specified in jar_order or glob_order file. * Bypasses filtering if none of the files is present in the directory. */ public void filterMatchedPathsByOrder()\ ``` - Yash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34105/#review85369 ----------------------------------------------------------- On May 28, 2015, 8:44 a.m., Yash Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34105/ > ----------------------------------------------------------- > > (Updated May 28, 2015, 8:44 a.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > Initial patch for - add jar should be able to take regex path and should be > able to add multiple jars. > > Jira: https://issues.apache.org/jira/browse/LENS-513 > > > Diffs > ----- > > > lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java > 3238edb > > lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java > 5ffc086 > lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java > PRE-CREATION > lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java > 01dcf54 > > Diff: https://reviews.apache.org/r/34105/diff/ > > > Testing > ------- > > Yes. > > Testcases: > New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex > Old testcase modified: TestLensConnectionCliCommands#testJarCommands > > Test on CLI: > > 1. -ve test scenario: > lens-shell>add jar /home/yash/Desktop/rt.jarr > No Jars found in the specified path. > lens-shell>add jar /home/yash/Desktop/*.jarr > No Jars found in the specified path. > > 2. +ve test scenario: > lens-shell>add jar /home/yash/Desktop/*.jar > Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar > /home/yash/Desktop/rt.jar ] > > lens-shell>list resources > type=jar path=/home/yash/Desktop/mahout-core-0.9.jar > type=jar path=/home/yash/Desktop/rt.jar > > > Complete build with testcases: > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 > s] > [INFO] Lens ............................................... SUCCESS [ 3.751 > s] > [INFO] Lens API ........................................... SUCCESS [ 19.844 > s] > [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 > s] > [INFO] Lens Cube .......................................... SUCCESS [03:06 > min] > [INFO] Lens DB storage .................................... SUCCESS [ 22.211 > s] > [INFO] Lens Query Library ................................. SUCCESS [ 19.126 > s] > [INFO] Lens Hive Driver ................................... SUCCESS [02:48 > min] > [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 > s] > [INFO] Lens Server ........................................ SUCCESS [06:03 > min] > [INFO] Lens client ........................................ SUCCESS [ 41.219 > s] > [INFO] Lens CLI ........................................... SUCCESS [02:09 > min] > [INFO] Lens Examples ...................................... SUCCESS [ 11.513 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 9.081 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [01:19 > min] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 > s] > [INFO] Lens Regression .................................... SUCCESS [ 8.067 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 18:46 min > [INFO] Finished at: 2015-05-12T19:44:01+05:30 > [INFO] Final Memory: 120M/389M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Yash Sharma > >
