> On June 22, 2015, 5:52 a.m., Rajat Khandelwal wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java, > > line 631 > > <https://reviews.apache.org/r/35459/diff/2/?file=988110#file988110line631> > > > > Do we need to add things to a set and then iterate over them > > separately? Can't we call `removeOptionalDim` here itself?
Yes. Otherwise it would result in ConcurrentModificationException > On June 22, 2015, 5:52 a.m., Rajat Khandelwal wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java, > > line 360 > > <https://reviews.apache.org/r/35459/diff/2/?file=988111#file988111line360> > > > > Looks like we could use > > `http://google-collections.googlecode.com/svn/trunk/javadoc/com/google/common/collect/HashMultimap.html` Dropping this change suggested. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35459/#review88731 ----------------------------------------------------------- On June 19, 2015, 9:25 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35459/ > ----------------------------------------------------------- > > (Updated June 19, 2015, 9:25 a.m.) > > > Review request for lens and Rajat Khandelwal. > > > Bugs: LENS-605 > https://issues.apache.org/jira/browse/LENS-605 > > > Repository: lens > > > Description > ------- > > Fixes Candidate pruning wrt sourcecolumns required for joinchains > > - Fixes when multiple tables not reachable for a candidate. Added regression > tests > - Fixed looking for dimensions required expression, existing testcases cover > the changes > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > 79d6d43 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > ae65287 > > lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java > 1a7b6b4 > lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java > 8e199ea > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java > a760599 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java > e615ccc > > Diff: https://reviews.apache.org/r/35459/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.575s] > [INFO] Lens .............................................. SUCCESS [3.227s] > [INFO] Lens API .......................................... SUCCESS [22.773s] > [INFO] Lens API for server and extensions ................ SUCCESS [20.788s] > [INFO] Lens Cube ......................................... SUCCESS [3:32.784s] > [INFO] Lens DB storage ................................... SUCCESS [19.930s] > [INFO] Lens Query Library ................................ SUCCESS [15.830s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:56.178s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [34.611s] > [INFO] Lens Server ....................................... SUCCESS [5:21.314s] > [INFO] Lens client ....................................... SUCCESS [37.142s] > [INFO] Lens CLI .......................................... SUCCESS [2:33.387s] > [INFO] Lens Examples ..................................... SUCCESS [9.229s] > [INFO] Lens Distribution ................................. SUCCESS [8.291s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:21.627s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.758s] > [INFO] Lens Regression ................................... SUCCESS [11.060s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 18:53.473s > [INFO] Finished at: Fri Jun 19 09:08:17 UTC 2015 > [INFO] Final Memory: 173M/1360M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Amareshwari Sriramadasu > >
