-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35459/
-----------------------------------------------------------
(Updated June 22, 2015, 6:58 a.m.)
Review request for lens and Rajat Khandelwal.
Changes
-------
Review comments fixed
Bugs: LENS-605
https://issues.apache.org/jira/browse/LENS-605
Repository: lens
Description
-------
Fixes Candidate pruning wrt sourcecolumns required for joinchains
- Fixes when multiple tables not reachable for a candidate. Added regression
tests
- Fixed looking for dimensions required expression, existing testcases cover
the changes
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java
79d6d43
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java
33b1a62
lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java
3ed94fa
lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java
8e199ea
lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a760599
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java
e615ccc
Diff: https://reviews.apache.org/r/35459/diff/
Testing (updated)
-------
Re-running tests with latest.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.575s]
[INFO] Lens .............................................. SUCCESS [3.227s]
[INFO] Lens API .......................................... SUCCESS [22.773s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.788s]
[INFO] Lens Cube ......................................... SUCCESS [3:32.784s]
[INFO] Lens DB storage ................................... SUCCESS [19.930s]
[INFO] Lens Query Library ................................ SUCCESS [15.830s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:56.178s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [34.611s]
[INFO] Lens Server ....................................... SUCCESS [5:21.314s]
[INFO] Lens client ....................................... SUCCESS [37.142s]
[INFO] Lens CLI .......................................... SUCCESS [2:33.387s]
[INFO] Lens Examples ..................................... SUCCESS [9.229s]
[INFO] Lens Distribution ................................. SUCCESS [8.291s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:21.627s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.758s]
[INFO] Lens Regression ................................... SUCCESS [11.060s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:53.473s
[INFO] Finished at: Fri Jun 19 09:08:17 UTC 2015
[INFO] Final Memory: 173M/1360M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu
