Thanks Raju & Rajat for the comments. Will look into it tonight and post updates.
Best Regards On Tue, Jul 21, 2015 at 12:17 PM, Rajat Khandelwal <rajatgupt...@gmail.com> wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36178/ > > On July 20th, 2015, 6:04 p.m. IST, *Raju Bairishetti* wrote: > > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java > <https://reviews.apache.org/r/36178/diff/5/?file=1016041#file1016041line155> > (Diff > revision 5) > > public static LensClientSingletonWrapper getClientWrapper() { > > 155 > > if (newPath.startsWith("file:/") && !newPath.startsWith("file://")) { > > *newPath.startsWith("file:/")* check is redundant. > > On July 20th, 2015, 6:08 p.m. IST, *Rajat Khandelwal* wrote: > > he's checking if path is file:/x/y/z and not file:///x/y/z, in that case, > convert it to file:///x/y/z. > > Yes. This is redundant. > > > - Rajat > > On July 19th, 2015, 4:10 p.m. IST, Yash Sharma wrote: > Review request for lens. > By Yash Sharma. > > *Updated July 19, 2015, 4:10 p.m.* > *Repository: * lens > Description > > Added changes for file name suggestions on Tab. Changed String file paths to > File. > > https://issues.apache.org/jira/browse/LENS-634 > > Testing > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.830 > s] > [INFO] Lens ............................................... SUCCESS [ 4.348 > s] > [INFO] Lens API ........................................... SUCCESS [ 19.880 > s] > [INFO] Lens API for server and extensions ................. SUCCESS [ 21.601 > s] > [INFO] Lens Cube .......................................... SUCCESS [03:41 > min] > [INFO] Lens DB storage .................................... SUCCESS [ 19.195 > s] > [INFO] Lens Query Library ................................. SUCCESS [ 13.843 > s] > [INFO] Lens Hive Driver ................................... SUCCESS [02:38 > min] > [INFO] Lens Driver for JDBC ............................... SUCCESS [ 37.845 > s] > [INFO] Lens Server ........................................ SUCCESS [05:03 > min] > [INFO] Lens client ........................................ SUCCESS [ 36.162 > s] > [INFO] Lens CLI ........................................... SUCCESS [02:10 > min] > [INFO] Lens Examples ...................................... SUCCESS [ 10.574 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 8.600 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [01:21 > min] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.812 > s] > [INFO] Lens Regression .................................... SUCCESS [ 12.166 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 18:05 min > [INFO] Finished at: 2015-07-19T16:00:17+05:30 > [INFO] Final Memory: 130M/428M > [INFO] ----------------------------------------------------------------------- > > Diffs > > - lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java > (74b4e91) > - lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java > (9cb7d69) > - > lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java > (8b4face) > - lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java > (6ba702f) > - > lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java > (de022c1) > - > lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java > (6a93393) > - lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java > (bdb9c38) > - > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java > (c48fabd) > - > lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java > (928120a) > - > lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java > (a479c14) > - > lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java > (7503221) > - lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java > (73661e1) > - lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java > (b6f96e6) > - lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java > (a22862e) > - > lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java > (a87d0b7) > - lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java > (13bfbd2) > - > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java > (73f3a78) > - lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java > (46e28a9) > - lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java > (3a04ec6) > - > lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java > (a5033fe) > - lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java > (92687c3) > - lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java > (715347f) > - src/site/apt/user/cli.apt (353c171) > > View Diff <https://reviews.apache.org/r/36178/diff/> >
