> On July 20, 2015, 7:30 a.m., Rajat Khandelwal wrote: > > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java, > > line 150 > > <https://reviews.apache.org/r/36178/diff/5/?file=1016041#file1016041line150> > > > > Can we use function of `UtilityMethods`?
Rather than using Server's Util class which might had caused circular dependency - moved it to API module where it can be used by other modules. > On July 20, 2015, 7:30 a.m., Rajat Khandelwal wrote: > > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java, > > line 146 > > <https://reviews.apache.org/r/36178/diff/5/?file=1016041#file1016041line146> > > > > Can be made static. Made changes. Also be moved to ApiUtilityMethods for reuse. > On July 20, 2015, 7:30 a.m., Rajat Khandelwal wrote: > > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java, > > line 169 > > <https://reviews.apache.org/r/36178/diff/5/?file=1016041#file1016041line169> > > > > Does this quit the cli? If it does, we might need to do something else > > here. It does not quit the CLI. It however shows error message like- lens-shell>add jar hdfs://test Command failed java.lang.RuntimeException: <Exception message here> > On July 20, 2015, 7:30 a.m., Rajat Khandelwal wrote: > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java, > > line 62 > > <https://reviews.apache.org/r/36178/diff/5/?file=1016045#file1016045line62> > > > > Can you update the cli behaviour in cases > > > > * path is passed > > * non existing path is passed > > * path not passed > > * path passed but is to a random file. > > * path to a directory is passed > > * anything else? > > > > I just want to make sure existing things don't break. > > > > In the long term we might have to change our testing strategy for CLI. > > http://docs.spring.io/spring-shell/docs/current/reference/htmlsingle/#d4e253 Scenarios tested: lens-shell>add file file:/usr/local/lens/README Add resource succeeded lens-shell>add file hdfs://localhost:9000/test/tempfiles/* Add resource succeeded lens-shell>add file hdfs:/localhost:9000/test/tempfiles/* Add resource succeeded lens-shell>add file hdfs:///localhost:9000/test/tempfiles/* Add resource succeeded lens-shell>add file hdfs:///test/tempfiles/* Add resource has failed lens-shell>add file file:/usr/local/lens/NON_EXISTING_PATH Add resource has failed lens-shell>add file --path You should specify a default option (otherwise known as option 'path') for this command lens-shell>add file You should specify a default option (otherwise known as option 'path') for this command lens-shell>add file file:/usr/local/lens/server/logs Add resource succeeded lens-shell>list resources type=file path=file:///usr/local/lens/README type=file path=hdfs://localhost:9000/test/tempfiles/tempdata_c.jar type=file path=hdfs://localhost:9000/test/tempfiles/tempdata_c.jar type=file path=hdfs://localhost:9000/test/tempfiles/tempdata_c.jar type=file path=file:///usr/local/lens/server/logs/lensserver-requests.log type=file path=file:///usr/local/lens/server/logs/lensserver.out.2015072121161437493595 type=file path=file:///usr/local/lens/server/logs/query-stats.log type=file path=file:///usr/local/lens/server/logs/server.pid type=file path=file:///usr/local/lens/server/logs/lensserver.log > On July 20, 2015, 7:30 a.m., Rajat Khandelwal wrote: > > src/site/apt/user/cli.apt, line 95 > > <https://reviews.apache.org/r/36178/diff/5/?file=1016063#file1016063line95> > > > > Can probably take care of these too if you have the time. Discussed on > > https://issues.apache.org/jira/browse/LENS-25. > > > > The documentation of debug and verbose commands looks out of place > > compared to other commands when seen through `mvn site:run`. Fixed. The help param was passed twice. - Yash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36178/#review92231 ----------------------------------------------------------- On July 22, 2015, 2:29 p.m., Yash Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36178/ > ----------------------------------------------------------- > > (Updated July 22, 2015, 2:29 p.m.) > > > Review request for lens. > > > Bugs: LENS-634 > https://issues.apache.org/jira/browse/LENS-634 > > > Repository: lens > > > Description > ------- > > Added changes for file name suggestions on Tab. Changed String file paths to > File. > > > https://issues.apache.org/jira/browse/LENS-634 > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/util/ApiUtilityMethods.java > PRE-CREATION > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java > bdfae24 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java > 9cb7d69 > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java > 8b4face > lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java > 6ba702f > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java > de022c1 > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java > 5fd80a1 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java > 5493dba > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java > c48fabd > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java > 928120a > > lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java > c505680 > > lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java > 7503221 > lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java > 73661e1 > lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java > b6f96e6 > lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java > a22862e > > lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java > 56e962d > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java > fa342c8 > > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java > 73f3a78 > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java > 46e28a9 > lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java > 3a04ec6 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 47d27d0 > > lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java > a5033fe > lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java > 92687c3 > src/site/apt/user/cli.apt 63f2b3f > > Diff: https://reviews.apache.org/r/36178/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 3.756 > s] > [INFO] Lens ............................................... SUCCESS [ 10.092 > s] > [INFO] Lens API ........................................... SUCCESS [ 22.157 > s] > [INFO] Lens API for server and extensions ................. SUCCESS [ 20.357 > s] > [INFO] Lens Cube .......................................... SUCCESS [03:36 > min] > [INFO] Lens DB storage .................................... SUCCESS [ 19.628 > s] > [INFO] Lens Query Library ................................. SUCCESS [ 14.736 > s] > [INFO] Lens Hive Driver ................................... SUCCESS [02:31 > min] > [INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.394 > s] > [INFO] Lens Server ........................................ SUCCESS [04:49 > min] > [INFO] Lens client ........................................ SUCCESS [ 37.127 > s] > [INFO] Lens CLI ........................................... SUCCESS [02:43 > min] > [INFO] Lens Examples ...................................... SUCCESS [ 9.946 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 7.965 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [01:24 > min] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.952 > s] > [INFO] Lens Regression .................................... SUCCESS [ 12.781 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 18:21 min > [INFO] Finished at: 2015-07-22T19:27:26+05:30 > [INFO] Final Memory: 130M/395M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Yash Sharma > >
