----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36853/ -----------------------------------------------------------
Review request for lens. Repository: lens Description ------- org.apache.lens.examples.PopulateSampleMetastore.createContinuousFactData() passes a nonconstant String to an execute or addBatch method on an SQL statement [org.apache.lens.examples.PopulateSampleMetastore] At PopulateSampleMetastore.java:[line 113] Code - statement.execute("INSERT INTO mydb_sales_aggr_continuous_fact (order_time, delivery_time, customer_id, " + "product_id, promotion_id, customer_city_id, production_city_id, delivery_city_id, unit_sales, " + "store_sales, store_cost, max_line_item_price, max_line_item_discount) values " + "('" + nowTime + "','" + nowTime + "',2,2,1,2,2,2,1,8,2,10,2)"); Diffs ----- lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java 5ba0ea6 Diff: https://reviews.apache.org/r/36853/diff/ Testing ------- Thanks, Yash Sharma