----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36853/#review93243 -----------------------------------------------------------
Ship it! lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java (line 51) <https://reviews.apache.org/r/36853/#comment147580> Please update summary of `mvn clean install -DskipTests` in testing done section. - Rajat Khandelwal On July 27, 2015, 11:32 p.m., Yash Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36853/ > ----------------------------------------------------------- > > (Updated July 27, 2015, 11:32 p.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > org.apache.lens.examples.PopulateSampleMetastore.createContinuousFactData() > passes a nonconstant String to an execute or addBatch method on an SQL > statement [org.apache.lens.examples.PopulateSampleMetastore] At > PopulateSampleMetastore.java:[line 113] > > Code - > statement.execute("INSERT INTO mydb_sales_aggr_continuous_fact (order_time, > delivery_time, customer_id, " > + "product_id, promotion_id, customer_city_id, production_city_id, > delivery_city_id, unit_sales, " > + "store_sales, store_cost, max_line_item_price, > max_line_item_discount) values " > + "('" + nowTime + "','" + nowTime + "',2,2,1,2,2,2,1,8,2,10,2)"); > > > Diffs > ----- > > > lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java > 5ba0ea6 > > Diff: https://reviews.apache.org/r/36853/diff/ > > > Testing > ------- > > > Thanks, > > Yash Sharma > >
