> On Aug. 8, 2015, 6:47 a.m., Rajat Khandelwal wrote: > > incubator-lens/lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java, > > line 831 > > <https://reviews.apache.org/r/36934/diff/2/?file=1035196#file1035196line831> > > > > Would it make sense to sum all file sizes in the directory?
Sum of size of all files in a directory can not asserted. This is because formatting would not happen if the final outputpath is a directory and fileSize is computed during formatting. - Deepak ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36934/#review94621 ----------------------------------------------------------- On Aug. 9, 2015, 11:16 a.m., Deepak Barr wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36934/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2015, 11:16 a.m.) > > > Review request for lens, Jaideep dhok and Pranav Agarwal. > > > Bugs: LENS-651 > https://issues.apache.org/jira/browse/LENS-651 > > > Repository: lens > > > Description > ------- > > Added file size in the /resultset api response in case of persistent resultset > > > Diffs > ----- > > > incubator-lens/lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java > 70dac08 > > incubator-lens/lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java > 88facda > > incubator-lens/lens-driver-es/src/main/java/org/apache/lens/driver/es/client/ESResultSet.java > 4ba2321 > > incubator-lens/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java > 3d1f20a > > incubator-lens/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java > 82b0568 > > incubator-lens/lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java > f80cdd8 > > incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java > 48e020f > > incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/HadoopFileFormatter.java > 2c48209 > > incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/WrappedFileFormatter.java > aa66b7b > > incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/ZipFileFormatter.java > cc6d918 > > incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java > af354cc > > incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java > 13f069f > > incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java > 0c78e01 > > incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryOutputFormatter.java > 1d2e89b > > incubator-lens/lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java > 17dc99b > > incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java > 80eb697 > > incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java > e392e34 > > incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 2983db4 > > incubator-lens/lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > beaa247 > > Diff: https://reviews.apache.org/r/36934/diff/ > > > Testing > ------- > > Yes. > > 1. Tested with various session conf for lens persistent,driver persistent and > inmemory resultset. > 2. Tested the output through APIs and CLI. > 3. Tested with compressed result set and split resultset. > 4. Tested the insertion and retrieval from finished queries table. > > > Thanks, > > Deepak Barr > >
