----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36934/#review94671 -----------------------------------------------------------
Ship it! Ship It! - Rajat Khandelwal On Aug. 9, 2015, 5:24 p.m., Deepak Barr wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36934/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2015, 5:24 p.m.) > > > Review request for lens, Jaideep dhok and Pranav Agarwal. > > > Bugs: LENS-651 > https://issues.apache.org/jira/browse/LENS-651 > > > Repository: lens > > > Description > ------- > > Added file size in the /resultset api response in case of persistent resultset > > > Diffs > ----- > > > incubator-lens/lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java > 70dac08 > > incubator-lens/lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java > 88facda > > incubator-lens/lens-driver-es/src/main/java/org/apache/lens/driver/es/client/ESResultSet.java > 4ba2321 > > incubator-lens/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java > 3d1f20a > > incubator-lens/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java > 82b0568 > > incubator-lens/lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java > f80cdd8 > > incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java > 48e020f > > incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/HadoopFileFormatter.java > 2c48209 > > incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/WrappedFileFormatter.java > aa66b7b > > incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/ZipFileFormatter.java > cc6d918 > > incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java > af354cc > > incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java > 13f069f > > incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java > 0c78e01 > > incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryOutputFormatter.java > 1d2e89b > > incubator-lens/lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java > 17dc99b > > incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java > 80eb697 > > incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java > e392e34 > > incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 2983db4 > > incubator-lens/lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > beaa247 > > Diff: https://reviews.apache.org/r/36934/diff/ > > > Testing > ------- > > Yes. > > 1. Tested with various session conf for lens persistent,driver persistent and > inmemory resultset. > 2. Tested the output through APIs and CLI. > 3. Tested with compressed result set and split resultset. > 4. Tested the insertion and retrieval from finished queries table. > > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 5.704 > s] > [INFO] Lens ............................................... SUCCESS [ 10.292 > s] > [INFO] Lens API ........................................... SUCCESS [ 38.121 > s] > [INFO] Lens API for server and extensions ................. SUCCESS [ 33.306 > s] > [INFO] Lens Cube .......................................... SUCCESS [09:16 > min] > [INFO] Lens DB storage .................................... SUCCESS [ 30.385 > s] > [INFO] Lens Query Library ................................. SUCCESS [ 22.183 > s] > [INFO] Lens Hive Driver ................................... SUCCESS [04:32 > min] > [INFO] Lens Driver for JDBC ............................... SUCCESS [ 57.032 > s] > [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 24.935 > s] > [INFO] Lens Server ........................................ SUCCESS [08:31 > min] > [INFO] Lens client ........................................ SUCCESS [ 49.693 > s] > [INFO] Lens CLI ........................................... SUCCESS [03:51 > min] > [INFO] Lens Examples ...................................... SUCCESS [ 14.025 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 13.169 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [02:15 > min] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 4.424 > s] > [INFO] Lens Regression .................................... SUCCESS [ 16.094 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 33:48 min > [INFO] Finished at: 2015-08-09T15:54:05+05:30 > [INFO] Final Memory: 209M/2440M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Deepak Barr > >