On Thu, 2006-09-21 at 12:30 +0200, Jörn Nettingsmeier wrote: > this little patch corrects invalid css statements. > can you please look at it and tell me if this bogus "display" value and > the comment are there for a reason? (it looks like it might be one of > those quirky browser-specific hacks, but since it's obviously invalid, > i'd a last like to see it commented if it has to stay.) > > if nobody objects, i'll submit it to svn.
Do you mean the "inline-block" display value? AFAIK it is understood by IE, see e.g. http://www.quirksmode.org/css/display.html#inlineblock The comment is probably a IE hack also, see http://de.selfhtml.org/css/layouts/browserweichen.htm#kommentar_hack (sorry, german link) But if your fix is tested with IE and Firefox, I'd be happy to see those hacks removed. Josias > > Index: src/webapp/lenya/resources/css/menu.xml > =================================================================== > --- src/webapp/lenya/resources/css/menu.xml (revision 441201) > +++ src/webapp/lenya/resources/css/menu.xml (working copy) > @@ -72,7 +72,7 @@ > > #lenya-areas ul li { list-style: none; float: left; display: block; > margin: 0 1px 0 0; } > > -#lenya-areas ul li a { color: #454646; display: block; text-decoration: > none; text-align: center; padding: 9px 9px 0 9px; height: 16px > !important; height /**/: 25px; display: inline-block; } > +#lenya-areas ul li a { color: #454646; display: block; text-decoration: > none; text-align: center; padding: 9px 9px 0 9px; height: 16px !important; } > > #lenya-areas ul li a span { font: bold 10px/1.0 Arial, Verdana, > sans-serif; text-transform: uppercase; vertical-align: top; } > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
