naturalett commented on a change in pull request #1:
URL: https://github.com/apache/incubator-liminal/pull/1#discussion_r524542086
##########
File path: scripts/liminal
##########
@@ -105,17 +108,15 @@ def deploy_liminal_apps(path, clean):
shutil.copyfile(config_file, target_yml_name)
def is_airflow_running():
- result = subprocess.check_output([f'docker-compose -f
"{environment.get_liminal_home()}/docker-compose.yml" ps'], shell=True,
universal_newlines=True)
+ result = docker_compose_command('check_output', 'ps', [])
return "liminal" in result
[email protected]("stop", short_help="stops the docker compose.")
[email protected]("stop", short_help="stops the docker compose")
def stop():
-
if docker_is_running() and is_airflow_running():
# initialize liminal home by default
environment.get_liminal_home()
- result = subprocess.call([f'docker-compose -f
"{environment.get_liminal_home()}/docker-compose.yml" down'],
- env=os.environ, shell=True)
+ docker_compose_command('call', 'down', [])
Review comment:
Yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
