assapin commented on a change in pull request #1:
URL: https://github.com/apache/incubator-liminal/pull/1#discussion_r524556056
##########
File path: scripts/liminal
##########
@@ -124,10 +125,17 @@ def start():
if docker_is_running():
# initialize liminal home by default
environment.get_liminal_home()
- result = subprocess.call(
- [f'docker-compose -f
"{environment.get_liminal_home()}/docker-compose.yml" up -d'],
- env=os.environ, shell=True)
- click.echo("Open Airflow in your browser. Please point your browser to
http://localhost:8080 to access Airflow.")
+ docker_compose_path, project_dir = get_docker_compose_paths()
+ docker_compose_command('call', 'up', ['-d'])
Review comment:
where is the stdout and err go? how can the user see them?
what feedback do users get that the process is successfully up and running?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
