Hi, Thanks for the patches and sorry for the late reply. I'm cc'ing the dev list.
On Mon, Feb 18, 2008 at 8:24 AM, Thomas Jaeger <[EMAIL PROTECTED]> wrote: > I've split the changes into two patches: the first, maximumize-overlap > adds an option to ignore windows that are already overlapping with the > current window, so that, for example, if there is a maximized (without > the 'um') window in the background, this won't prevent "maximumization". This was applied. There are currently two bits of code dealing with partial overlapping which should share variables (your code and the existing "shrink" code), but that could be an other task. > The second one restores the original size of the window if > maximumization would otherwise be a no-op, which effectively allows > toggling of maximumization. This one was actually pretty annoying to > implement since adding state to windows is more painful than it should be. This one is not committed for a few reasons. First off all the private index macros and similar should be located at the top of the file, as is custom for compiz plugins (look at any other plugin for examples), the same style should be used. The private window info should also NOT just be an XWindowsChanges struct, as this means if any other part of the code require storing window state, it would have to re-do the struct anyway. It also reduces readability quite a lot. The maximumizeGetMask function needs a description. maximumizeGetWindowInfo should be a macro, and a helper macro for defining mw should exist named MAXIMUMIZE_WINDOW (CompWindow *w), which just defines mw and gets a value for it, similar to other compiz plugins. Essentially, it's just all the window private data that needs to be brought in line with the other compiz plugins. - Kristian _______________________________________________ Dev mailing list [email protected] http://lists.compiz-fusion.org/mailman/listinfo/dev
