Thomas Jaeger wrote:
>>>  I've split the changes into two patches:  the first,
>>> maximumize-overlap
>>>  adds an option to ignore windows that are already overlapping with the
>>>  current window, so that, for example, if there is a maximized (without
>>>  the 'um') window in the background, this won't prevent
>>> "maximumization".
>>>     
> In its current form, this doesn't quite work: If an overlapping window
> is followed by a dock, its region is subtracted in the next iteration
> of the loop. This looks like a copy-and-paste related editing error;
> maximumize-remove-spurious-union.patch takes the offending line out.
Could someone with git access please apply at least this patch?  The
ignore overlapping windows option is completely broken at this point.

Tom
diff --git a/maximumize.c b/maximumize.c
index 0f11aa4..8b20364 100644
--- a/maximumize.c
+++ b/maximumize.c
@@ -97,7 +97,6 @@ maximumizeEmptyRegion (CompWindow *window,
 		XUnionRectWithRegion (&w->struts->right, tmpRegion, tmpRegion);
 		XUnionRectWithRegion (&w->struts->top, tmpRegion, tmpRegion);
 		XUnionRectWithRegion (&w->struts->bottom, tmpRegion, tmpRegion);
-		XUnionRectWithRegion (&tmpRect, tmpRegion, tmpRegion);
 		XSubtractRegion (newRegion, tmpRegion, newRegion);
 	    }
 	    continue;
_______________________________________________
Dev mailing list
[email protected]
http://lists.compiz-fusion.org/mailman/listinfo/dev

Reply via email to