On 09/01/2015 06:48 PM, Michał Masłowski wrote: >> -+ ti,pm-firmware = "am335x-pm-firmware.elf"; >> ++ ti,pm-firmware = "/*(DEBLOBBED)*/"; > > Ok by policy. >
+1 >> -+ ret = of_property_read_string(dev->of_node, "ti,pm-firmware", >> ++ ret = of_property_read_string(dev->of_node, "/*(DEBLOBBED)*/", > > We know that name from the above device tree file, it shouldn't get > deblobbed here. > Ok, i'll revert it then, no problem. >> -diff --git a/firmware/am335x-bone-scale-data.bin > > Don't include contents of removed binary files in the repo. > Ok, i agree, i'm including a deblobbed rcn patch without contents about it, diff posted here is to check false positives only. >> b/firmware/am335x-bone-scale-data.bin >> -new file mode 100644 >> -index >> 0000000000000000000000000000000000000000..296903ec2c0fe1518566039b601b445c270e1c98 >> -GIT binary patch >> -literal 72 >> -ocmd-HXHa4=VN&7FWl|AfLZWk+R0P|Ad@v1H!2wkPqES=;07<$Dx&QzG >> - >> -literal 0 >> -HcmV?d00001 > > What is that file? > >> -diff --git a/firmware/am335x-evm-scale-data.bin >> b/firmware/am335x-evm-scale-data.bin >> -new file mode 100644 >> -index >> 0000000000000000000000000000000000000000..7e18ce7208b7d0d669dd6e199a7969bf98a74ee8 >> -GIT binary patch >> -literal 16 >> -Tcmd-HXJBJ6VbWEV2b0<W4kZD^ >> - >> -literal 0 >> -HcmV?d00001 > > Also too small to be a firmware. > >> -diff --git a/firmware/am43x-evm-scale-data.bin >> b/firmware/am43x-evm-scale-data.bin >> -new file mode 100644 >> -index >> 0000000000000000000000000000000000000000..805338a032540ab0f1cab3b44693768bd2dab018 >> -GIT binary patch >> -literal 40 >> -gcmd-HXAojAVNwyuW>OLB0@CSBDpGB5k(n?N0C+M6fdBvi >> - >> -literal 0 >> -HcmV?d00001 >> - > > As above. > Those files are board specific voltage scaling binaries [0], and they are in the same source/folder [1] than am335x-pm-firmware.bin and am335x-pm-firmware.elf with the same license [2], therefore are nonfree and should be removed too. [0]:http://git.ti.com/gitweb/?p=ti-cm3-pm-firmware/amx3-cm3.git;a=commit;h=fffeab4236d4129ab046bb7081a8ac244134ad89 [1]:http://git.ti.com/gitweb/?p=ti-cm3-pm-firmware/amx3-cm3.git;a=tree;f=bin;h=253f8c97b9e40ffc9c97b39e4d9a0cad6e6df2cb;hb=fffeab4236d4129ab046bb7081a8ac244134ad89 [2]:http://git.ti.com/gitweb/?p=ti-cm3-pm-firmware/amx3-cm3.git;a=blob;f=License.txt;h=198e640df05166519de32dfdaa5b076f98a33062;hb=fffeab4236d4129ab046bb7081a8ac244134ad89
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Dev mailing list [email protected] https://lists.parabola.nu/mailman/listinfo/dev
