On Wed, 2023-06-07 at 12:44 -0400, bill-auger wrote: > i am mostly wondering, why should this conflict with 'extra/flashrom' - > because > of file conflicts, sure; but are both needed? - is 'extra/flashrom' still > desirable? or undesirable, or redundant? - is rustiness it's only problem? > > some notes about the PKGBUILD: > > the PKGBUILD builds from VCS, and does not specify a commit, only a tag, which > makes it not reproducible - most likely, that could be changed; but we prefer > to > avoid VCS sources whenever possible anyways - i found that the upstream VCS > can generate tarballs; so i tried changing the source to the tarball (also > eliminating the 'git' makedepends) - you probably would not have found that > tarball - i did not see it on their website - i simply guessed the filename, > and it is available in that form > > however, the tarball is not reproducible either - every download yields a > different file - i devised an ugly way to verify the VCS files; but i would > discuss this with the arch packager and/or the upstream - ideally, try to > convince the upstream to fix their git service; so that it generates > reproducible tarballs - as a last resort, try to convince the arch packager to > specify the commit hash at the tag, at least - that is how i see it done in > most arch PKGBUILDs built from VCS, like: > > _commit=0123456789 # <- this is tag 'v1.2.3' > > they do it that way; because git tags are not stable - the "is" above could > become "was" at any time - the PKGBUILD may still verify the (new) signature; > but it is not truly checking the integrity of the sources, as a tarball > checksum does > > a reminder: never put "# Maintainer (Parabola):" - simply "# Maintainer:" and > use lowercase for # Maintainer (aur): - that has no meaning currently; but i > have been normalizing all of these, so that th > _______________________________________________ > Dev mailing list > [email protected] > https://lists.parabola.nu/mailman/listinfo/dev
As to why it should conflict with "vanilla" flashrom, because it is a fork thereof and they share a lot of the core code and files - that I think that is pretty obvious. Rust was just one example of one of the issues and why this fork exists, as it is happening now, most of the new development and work towards board support is being done on flashrom-stable (don't let the name mislead you, it is a much more active project), and in general since it is under the wings of Coreboot it has more eyes on the code and much better support - especially with Coreboot developers that are reverse-engineering a lot of boards and chips, that knowledge gets contributed in directly. As for the rest, I've added the fixes you told me about - the 'patches' file is just one file with both of the patches (that I've added separately). In any case, I'll also be contacting Nico Huber, being also the maintainer of the AUR PKGBUILD. -- Kind Regards, Wael Karram.
From 2a11fd33e02c18a67609b126b9700b76757bdfb4 Mon Sep 17 00:00:00 2001 From: Wael Karram <[email protected]> Date: Thu, 25 May 2023 19:16:42 +0300 Subject: [PATCH 1/2] Added PKGBUILD for flashrom-stable, a Coreboot-maintained fork of flashrom. --- pcr/flashrom-stable/PKGBUILD | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) create mode 100644 pcr/flashrom-stable/PKGBUILD diff --git a/pcr/flashrom-stable/PKGBUILD b/pcr/flashrom-stable/PKGBUILD new file mode 100644 index 000000000..770a44789 --- /dev/null +++ b/pcr/flashrom-stable/PKGBUILD @@ -0,0 +1,35 @@ +# Maintainer (AUR): Nico Huber <[email protected]> +# Maintainer (Parabola): Wael Karram <[email protected]> + +# Parabola Changes and Rationale: +# This package exists as an alternative to the rust-ridden flashrom +# Change of compilation targets to what is relevant for Parabola. + +pkgname="flashrom-stable" +pkgdesc="Flashrom is a utility which can be used to detect, read, erase, or write BIOS chips (DIP, PLCC, SPI)." +pkgver=1.1 +pkgrel=1 +url="https://review.coreboot.org/plugins/gitiles/flashrom-stable"; +license=('GPL') +source=(git+https://review.coreboot.org/flashrom-stable.git?signed#tag=v${pkgver}) +validpgpkeys=('2853079C9C66AB7E82C64966A5C163B7E557CAEB') +sha256sums=('SKIP') +depends=('pciutils' 'libusb' 'libftdi' 'libjaylink' 'libgpiod') +makedepends=('git' 'make') +optdepends=("dmidecode: for SMBIOS/DMI table decoder support") +conflicts=("flashrom") +arch=('armv7h' 'i686' 'x86_64') + +build() { + cd "${srcdir}/${pkgname}" + make +} + +package() { + cd "${srcdir}/${pkgname}" + install -d "${pkgdir}/usr/bin" + install -d "${pkgdir}/usr/man/man8" + install -m 0755 flashrom "${pkgdir}/usr/bin/" + install -m 0644 flashrom.8 "${pkgdir}/usr/man/man8/" + install -m 0755 util/ich_descriptors_tool/ich_descriptors_tool "${pkgdir}/usr/bin/" +} -- 2.41.0
From c04487e52afdfabea5ec8f3c5c5e589bbf62dd24 Mon Sep 17 00:00:00 2001 From: Wael Karram <[email protected]> Date: Thu, 8 Jun 2023 05:23:56 +0300 Subject: [PATCH 2/2] fixed maintainer attribution, clarified reasons for package existence, building from tarball --- pcr/flashrom-stable/PKGBUILD | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/pcr/flashrom-stable/PKGBUILD b/pcr/flashrom-stable/PKGBUILD index 770a44789..6d9746703 100644 --- a/pcr/flashrom-stable/PKGBUILD +++ b/pcr/flashrom-stable/PKGBUILD @@ -1,8 +1,9 @@ -# Maintainer (AUR): Nico Huber <[email protected]> -# Maintainer (Parabola): Wael Karram <[email protected]> +# Maintainer (aur): Nico Huber <[email protected]> +# Maintainer: Wael Karram <[email protected]> # Parabola Changes and Rationale: -# This package exists as an alternative to the rust-ridden flashrom +# This package exists as an alternative to the rust-ridden flashrom. +# Most of the newer development is happening in this branch too, as part of Coreboot. # Change of compilation targets to what is relevant for Parabola. pkgname="flashrom-stable" @@ -11,22 +12,24 @@ pkgver=1.1 pkgrel=1 url="https://review.coreboot.org/plugins/gitiles/flashrom-stable"; license=('GPL') -source=(git+https://review.coreboot.org/flashrom-stable.git?signed#tag=v${pkgver}) -validpgpkeys=('2853079C9C66AB7E82C64966A5C163B7E557CAEB') -sha256sums=('SKIP') +source=("https://download.flashrom.org/flashrom-stable/releases/flashrom-stable-v${pkgver}.tar.bz2"; + "https://download.flashrom.org/flashrom-stable/releases/flashrom-stable-v${pkgver}.tar.bz2.asc";) +validpgpkeys=('2853079C9C66AB7E82C64966A5C163B7E557CAEB') # Nico Huber - GPG +sha256sums=('8f7a5cefcb59be9994464031af5fea8e073b58e51b2b312155fecdd8298f1141' + 'SKIP') depends=('pciutils' 'libusb' 'libftdi' 'libjaylink' 'libgpiod') -makedepends=('git' 'make') +makedepends=('make') optdepends=("dmidecode: for SMBIOS/DMI table decoder support") conflicts=("flashrom") arch=('armv7h' 'i686' 'x86_64') build() { - cd "${srcdir}/${pkgname}" + cd "${srcdir}/${pkgname}-v${pkgver}" make } package() { - cd "${srcdir}/${pkgname}" + cd "${srcdir}/${pkgname}-v${pkgver}" install -d "${pkgdir}/usr/bin" install -d "${pkgdir}/usr/man/man8" install -m 0755 flashrom "${pkgdir}/usr/bin/" -- 2.41.0
patches
Description: application/mbox
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Dev mailing list [email protected] https://lists.parabola.nu/mailman/listinfo/dev
