Re: Mail priority patch

[Craig Webster]

Thomas, On 6 Jun 2006, at 09:34, Thomas Bruederli wrote: I cannot confirm this as an error. Unfortunately I could not find any RFCs specifying the priority-number assignment. I tested it with Thunderbird and it shows the same behavior as RoundCube does: X-Priority: 1 (Highest) Also GMX uses 1 as value for high priority: x-priority: 1 Please somebody show me some spec to this otherwise we will keep the current behavior and reject the ticket. The problem isn't non-conformance to a spec (although I've not seen any spec either so I can't confirm that). Now that I've had some coffee I can see that I've edited the wrong file. The problem is that, using changeset 259, when you choose "Highest Priority" in the interface, the delivered email has a header "X-Priority: 1 (Lowest)" where it should be saying "X-Priority: 1 (Highest)". http://beer-monkey.com/media/roundcube/composing.png http://beer-monkey.com/media/roundcube/received-raw.png This doesn't match expected interface behaviour, and it doesn't match your Thunderbird example; the word in brackets is at the wrong end of the scale.   To fix this, in program/steps/mail/sendmail.inc line 134 curerntly reads    $a_priorities = array(1=>'lowest', 2=>'low', 4=>'high', 5=>'highest'); where it should read   $a_priorities = array(5=>'lowest', 4=>'low', 2=>'high', 1=>'highest'); ie the numbers should be reversed. This should give us headers "X-Priority: 1 (Highest)" and "X-Priority: 5 (Lowest)" Unfortunately I have to start working again now so don't have time to update the patch. Yours, Craig -- Craig Webster | t: +44 (0)131 516 8595 | e: [EMAIL PROTECTED] Xeriom.NET    | f: +44 (0)131 661 0689 | w: http://xeriom.net