Robin Elfrink wrote:
> Hi,
> 
Hi Robin
> 
> Attached patch shifts focus to the password field if 'enter' was pressed
> inside the username field.
> 
> I would commit this without asking if I weren't concerned about wether I
> placed the new 'login form methods' block in the right place, and using
> the proper reference vars etc.

I don't see any usage of the method 'init_login_form_events'. What's it
good for?

To set the focus you should to use rcube_find_object('_pass') instead of
directly accessing document.form._pass.

And one last suggestion:
var key = e && e.keyCode ? e.keyCode : event.keyCode;

Event properties actually have nothing to do with document.*
> 
> Thomas, is this OK?
> 
Go ahead and commit the changes.

Thanks!
~Thomas


Reply via email to