Thomas Bruederli wrote:

> I don't see any usage of the method 'init_login_form_events'. What's it
> good for?

It adds an event listener to the username input box. I created (actually
mostly copied) this function in case we need more
login-screen-initialization in the future.


> To set the focus you should to use rcube_find_object('_pass') instead of
> directly accessing document.form._pass.

Yes, that was stupid. Thanks.


> And one last suggestion:
> var key = e && e.keyCode ? e.keyCode : event.keyCode;
> 
> Event properties actually have nothing to do with document.*

Duh. I copied the line from function this.name_input_keypress(). I see
now that that function handles document-wide key events.



Robin


Reply via email to