On Fri, Feb 29, 2008 at 11:31 AM, Michael Baierl <[EMAIL PROTECTED]> wrote: > Maximilien Cuony [The_Glu] wrote: > > - - - Notice: Undefined index: _step in > > /var/www/webmail/tmp/trunk/roundcubemail/installer/rcube_install.php on > > line 39 > These are just noticies so I think they are fine in there - notices > should be disabled anyways - if you code around undefined index notices > it will make your life much harder and your code even more unreadable.
I'll disable notices using ini_set()... > > > > Shouldn't you disable the installer, or protect it when a configuration > > file already exist ? Because for the moment, I just have to go to > > /installer to get the configuration options of an Roundcube installation... > > Yes there are a warning, but... > Yeah, this should be done. And as you can't expect that you can write to > the install dir > -) offer the config script for downloading as well > -) only allow configuration if a file install.allow exists > -) warn the user on the login page that install.allow must be removed > if it still exists. > > That way noone can access the install script and the admin has to > actively enable it and hopefully he also disables it to get rid of the > message on the login screen. I planned to check whether the installer folder exists when showing the login page and display a big fat warning. This should be enough motivation for the admin to remove the installer after use. Thanks so far! ~Thomas _______________________________________________ List info: http://lists.roundcube.net/dev/
