On Wed, 15 Apr 2009 13:12:53 +0200, "A.L.E.C" <[email protected]> wrote:
> some issues. One thing, rcube_sess_unset() and rcube_sess_write() are > not atomic (should we use SELECT FOR UPDATE?). Is that MySQL-specific? >> php's unserialize() doesn't handle the >> 'name|serializeddata;othername|serializeddata;' structure. > > I see now, it's needed for data merging. session_real_decode() from > comments to http://php.net/manual/en/function.session-decode.php should > be better. That looks more solid than my simple preg_split(). Used that in attached patch. Any other comments? I'd like to submit this; it will make some people very happy :) We can handle the non-atomicness later. Robin --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/AT/exvuhi5l/_1485659.20090415152.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---
_______________________________________________ List info: http://lists.roundcube.net/dev/
