On Wed, 15 Apr 2009 15:39:03 +0200, till <[email protected]> wrote:

>>> some issues. One thing, rcube_sess_unset() and rcube_sess_write() are
>>> not atomic (should we use SELECT FOR UPDATE?).
>>
>> Is that MySQL-specific?
> 
> I don't think. Postgres and Oracle do that (as well).

As far as I can see 'SELECT ... FOR UPDATE' is an SQL92 standard, so I
added that.

Also, rcube_sess_unset did unset, but the rcube_sess_write in it undid the
unset again :) Fixed that.


Robin


 --- 8< --- detachments --- 8< ---
 The following attachments have been detached and are available for viewing.
  http://detached.gigo.com/rc/Jt/6IqQQ4kn/_1485659.20090415161.patch
 Only click these links if you trust the sender, as well as this message.
 --- 8< --- detachments --- 8< ---

_______________________________________________
List info: http://lists.roundcube.net/dev/

Reply via email to