On Sat, May 23, 2009 at 4:44 AM, Dave Rowe <[email protected]> wrote: > till wrote: >> >> On Fri, May 22, 2009 at 9:39 PM, Kevin Landers <[email protected]> wrote: >>> >>> Go here: >>> >>> http://www.roundcubeforum.net/requests/598-signature-above-quoted-text-reply.html#post3200 >> >> Just to add to this without fueling the fire. :-) Of course you can do >> whatever you want -- this is opensource! I also totally get why people >> want it, but I am not a fan of patching the core code of RoundCube. >> >> Reasons: >> a) Makes maintenance harder (you will have to re-patch it with each >> update). >> >> b) This patching generally leads to people updating less -- and we are >> not a 1.0 yet. There can be issues. Just remember the exploits from >> last year who were in 3rd party libs and we rolled out an update right >> away, but the worm in January/February still hit a lot of >> installations. >> >> Till > > This is something that interests me, from the standpoint of getting (albeit, > a small bit) deeper into the RC code. A relatively simple modification, > that _helps_ someone. > > Based on the previous message (your reply to me) a patch would be welcome, > but then in this message, you note that you're not a fan of patching the > core code of RoundCube. It may be a simple misunderstanding on my part, but > are you meaning patching in the context of that forum posts solution, or > patching for this feature altogether? > > What I'd prefer is a preference / setting (like you mentioned, per identity) > determining where the cursor should be on replies, as well as, including the > signature above the quote, on a reply. Would this be a patch that would be > more well received? > > Thanks! > Dave
Mis-understanding. I don't recommend the patching of a .js file to people. The solution on the forum doesn't add anything, it just changes the default behavior for an entire install. If you want to supply a patch to make this an option for the user, that's totally fine and appreciated. Till _______________________________________________ List info: http://lists.roundcube.net/dev/
