On 09/18/2013 12:11 PM, David Deutsch wrote: > So you're saying a clean commit history is more important than giving me > proper credit where it is due? Again, that is not acceptable. Besides - why > is the commit history that important to begin with?
Sorry, but you need to accept our commit rules the same as code style rules. I quite often check commits history of specified file and in most cases code-style changes are irrelevant. It's simpler to skip one commit than 60. You'll have your credit with merged pull request but this must be good request. You really think we should accept commits with stupid (sorry to say that, but in context of commit history it is stupid) "good catch indeed!" or "yup" message? What I'm supposed to think about it when I'll review the history? -- Aleksander 'A.L.E.C' Machniak LAN Management System Developer [http://lms.org.pl] Roundcube Webmail Developer [http://roundcube.net] --------------------------------------------------- PGP: 19359DC1 @@ GG: 2275252 @@ WWW: http://alec.pl _______________________________________________ Roundcube Development discussion mailing list [email protected] http://lists.roundcube.net/mailman/listinfo/dev
