Re: [Dev] Gerrit: review result isn't cleaned after upload new chagnes.

Hi Junfeng Dong,

-2 Do not submit

The code is so horribly incorrect/buggy/broken that it must not be submitted to this project, or to this branch. This value is valid across all patch sets in the same change, i.e. the reviewer must actively change his/her review to something else before the change is submittable.

Any -2 blocks submit.

You need to discuss it with Lukasz and show him that the change addressed the mentioned issue correctly.

Cheers,

MyungJoo.

------- Original Message -------

Sender : Dong, Junfeng<[email protected]>

Date : 2014-01-06 19:22 (GMT+09:00)

Title : [Dev] Gerrit: review result isn't cleaned after upload new chagnes.

Hi Gerrit administer,

When uploading new patch set, the review result for the former changes isn’t cleaned. This seems unreasonable. Could you please fix this?

Thanks

Junfeng

MyungJoo Ham (함명주), PHD

System S/W Lab, S/W Platform Team, Software Center
Samsung Electronics
Cell: +82-10-6714-2858

_______________________________________________
Dev mailing list
[email protected]
https://lists.tizen.org/listinfo/dev

Reply via email to